Skip to content

Commit

Permalink
Aaand fix IE8 again
Browse files Browse the repository at this point in the history
  • Loading branch information
dcodeIO committed Dec 9, 2016
1 parent 7983ee0 commit a5ad0c1
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
12 changes: 6 additions & 6 deletions dist/protobuf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/protobuf.js.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/protobuf.min.js

Large diffs are not rendered by default.

Binary file modified dist/protobuf.min.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion dist/protobuf.min.js.map

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions src/class.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Class.create = function create(type, ctor) {
var prototype = clazz.prototype = new Message();
prototype.constructor = clazz;

// Static methods on Message are instance methods on Class and vice-versa.
// Static methods on Message are instance methods on Class and vice versa.
util.merge(clazz, Message, true);

// Classes and messages reference their reflected type
Expand All @@ -65,7 +65,7 @@ Class.create = function create(type, ctor) {
: field.defaultValue;
});

// Runtime messages have non-enumerable getters and setters for each virtual oneof field
// Messages have non-enumerable getters and setters for each virtual oneof field
type.getOneofsArray().forEach(function(oneof) {
util.prop(prototype, oneof.resolve().name, {
get: function getVirtual() {
Expand All @@ -86,12 +86,12 @@ Class.create = function create(type, ctor) {
});

// Register
type.ctor = clazz;
type.setCtor(clazz);

return prototype;
};

// Static methods on Message are instance methods on Class and vice-versa.
// Static methods on Message are instance methods on Class and vice versa.
Class.prototype = Message;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/type.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ util.props(TypePrototype, {
},
set: function setCtor(ctor) {
if (ctor && !(ctor.prototype instanceof Message))
throw util._TypeError("ctor", "a constructor inheriting from Message");
throw util._TypeError("ctor", "a Message constructor");
this._ctor = ctor;
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/classes.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ tape.test("google.protobuf.Any class", function(test) {
function Any(properties) {
Message.call(this, properties);
}
Any.prototype = Class.create(root.lookup("google.protobuf.Any"), Any);
/* Any.prototype = */ Class.create(root.lookup("google.protobuf.Any"), Any);

var valueBuffer = protobuf.util.newBuffer(0);
var any = new Any({
Expand Down

0 comments on commit a5ad0c1

Please sign in to comment.