Skip to content

Commit

Permalink
Actually allow undefined as service method type, fixes #528
Browse files Browse the repository at this point in the history
  • Loading branch information
dcodeIO committed Dec 7, 2016
1 parent df91b1f commit 98a58d4
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions dist/protobuf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/protobuf.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/protobuf.min.js

Large diffs are not rendered by default.

Binary file modified dist/protobuf.min.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion dist/protobuf.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/method.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function Method(name, type, requestType, responseType, requestStream, responseSt
options = responseStream;
responseStream = undefined;
}
if (!util.isString(type))
if (type && !util.isString(type))
throw _TypeError("type");
if (!util.isString(requestType))
throw _TypeError("requestType");
Expand Down

0 comments on commit 98a58d4

Please sign in to comment.