Skip to content

Commit

Permalink
Moved extend implementation to its own micromodule, might help with #560
Browse files Browse the repository at this point in the history
; tsd-jsdoc progress
  • Loading branch information
dcodeIO committed Dec 15, 2016
1 parent a834250 commit 75f4b6c
Show file tree
Hide file tree
Showing 23 changed files with 378 additions and 109 deletions.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ protobuf.js version: <fill in>
### How to reproduce ###

```js
<code snippet>
<please add a code snippet>
```

### Expected behaviour ###
### Expected behavior ###

<please describe>

### Actual behaviour ###
### Actual behavior ###

<please describe>
2 changes: 1 addition & 1 deletion cli/pbts.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ exports.main = function(args) {

// There is no proper API for jsdoc, so this executes the CLI and pipes the output
var basedir = path.join(__dirname, "..");
var moduleName = argv.name || "mymodule";
var moduleName = argv.name || "null";
var child = child_process.exec("node \"" + basedir + "/node_modules/jsdoc/jsdoc.js\" -c \"" + basedir + "/jsdoc.types.json\" -q \"module=" + encodeURIComponent(moduleName) + "\" " + files.map(function(file) { return '"' + file + '"'; }).join(' '), {
cwd: process.cwd(),
argv0: "node",
Expand Down
100 changes: 54 additions & 46 deletions dist/protobuf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/protobuf.js.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/protobuf.min.js

Large diffs are not rendered by default.

Binary file modified dist/protobuf.min.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion dist/protobuf.min.js.map

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/runtime/protobuf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/runtime/protobuf.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/runtime/protobuf.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified dist/runtime/protobuf.min.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion dist/runtime/protobuf.min.js.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions lib/tsd-jsdoc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ Options
Wraps everything in a module of the specified name.

* **private: `boolean`**<br />
Skips private members when set to `false`.
Includes private members when set to `true`.

* **comments: `boolean`**<br />
Skips any comments when set to `false`.
Skips comments when explicitly set to `false`.

* **destination: `string|boolean`**<br />
Saves to the specified destination file or to console when set to `false`.

Setting options on the command line
-----------------------------------
Providing `-q, --query <queryString>` on the command line will set respectively override existing options.
Providing `-q, --query <queryString>` on the command line will set respectively override existing options. Example: `-q module=protobufjs`
Loading

0 comments on commit 75f4b6c

Please sign in to comment.