Skip to content

Commit

Permalink
Use protobuf/minimal when pbjs target is static-module
Browse files Browse the repository at this point in the history
  • Loading branch information
betalb committed May 30, 2017
1 parent bb9f1fc commit 4eac28c
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
4 changes: 3 additions & 1 deletion cli/pbjs.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ exports.main = function main(args, callback) {
"force-long": "strict-long",
"force-message": "strict-message"
},
string: [ "target", "out", "path", "wrap", "root", "lint" ],
string: [ "target", "out", "path", "wrap", "dependency", "root", "lint" ],
boolean: [ "create", "encode", "decode", "verify", "convert", "delimited", "beautify", "comments", "es6", "sparse", "keep-case", "force-long", "force-number", "force-enum-string", "force-message" ],
default: {
target: "json",
Expand Down Expand Up @@ -101,6 +101,8 @@ exports.main = function main(args, callback) {
" es6 ES6 wrapper (implies --es6)",
" closure Just a closure adding to protobuf.roots (see -r)",
"",
" --dependency Specifies which version of protobuf to require. Accepts any valid module id",
"",
" -r, --root Specifies an alternative protobuf.roots name.",
"",
" -l, --lint Linter configuration. Defaults to protobuf.js-compatible rules:",
Expand Down
4 changes: 3 additions & 1 deletion cli/targets/json-module.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ module.exports = json_module;

var util = require("../util");

var protobuf = require("../..");

json_module.description = "JSON representation as a module";

function json_module(root, options, callback) {
Expand All @@ -17,7 +19,7 @@ function json_module(root, options, callback) {
}
var json = util.jsonSafeProp(JSON.stringify(root.nested, null, 2).trim());
output.push(".addJSON(" + json + ");");
output = util.wrap(output.join(""), options);
output = util.wrap(output.join(""), protobuf.util.merge({ dependency: "protobufjs/minimal" }, options));
process.nextTick(function() {
callback(null, output);
});
Expand Down
2 changes: 1 addition & 1 deletion cli/wrappers/amd.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
define(["protobuf"], function($protobuf) {
define([$DEPENDENCY], function($protobuf) {
"use strict";

$OUTPUT;
Expand Down
2 changes: 1 addition & 1 deletion cli/wrappers/default.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(function(global, factory) { /* global define, require, module */

/* AMD */ if (typeof define === 'function' && define.amd)
define(["protobuf"], factory);
define([$DEPENDENCY], factory);

/* CommonJS */ else if (typeof require === 'function' && typeof module === 'object' && module && module.exports)
module.exports = factory(require($DEPENDENCY));
Expand Down
2 changes: 1 addition & 1 deletion cli/wrappers/es6.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as $protobuf from "protobufjs";
import * as $protobuf from $DEPENDENCY;

$OUTPUT;

Expand Down

1 comment on commit 4eac28c

@yejinjian
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "json-module" also default use " protobuf/minimal "?
"protobuf/minimal" did not have function "Root()".

Please sign in to comment.