Skip to content

Commit

Permalink
pbjs: Removed type/ns alias comment in static target to not confuse j…
Browse files Browse the repository at this point in the history
…sdoc unnecessarily
  • Loading branch information
dcodeIO committed Dec 19, 2016
1 parent 99ad9cc commit 3e7e4fc
Show file tree
Hide file tree
Showing 12 changed files with 5 additions and 18 deletions.
1 change: 0 additions & 1 deletion cli/targets/static.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ function buildNamespace(ref, ns) {
return;
if (ns.name !== "") {
push("");
push("/** @alias " + ns.fullName.substring(1) + " */");
push(name(ref) + "." + name(ns.name) + " = (function() {");
++indent;
}
Expand Down
2 changes: 1 addition & 1 deletion dist/protobuf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/protobuf.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified dist/protobuf.min.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion dist/runtime/protobuf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/runtime/protobuf.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified dist/runtime/protobuf.min.js.gz
Binary file not shown.
2 changes: 0 additions & 2 deletions tests/data/ambiguous-names.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ var $lazyTypes = [];
// Exported root namespace
var $root = {};

/** @alias A */
$root.A = (function() {

/**
Expand Down Expand Up @@ -139,7 +138,6 @@ $root.A = (function() {
return A;
})();

/** @alias B */
$root.B = (function() {

/**
Expand Down
5 changes: 0 additions & 5 deletions tests/data/mapbox/vector_tile.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ var $lazyTypes = [];
// Exported root namespace
var $root = {};

/** @alias vector_tile */
$root.vector_tile = (function() {

/**
Expand All @@ -18,7 +17,6 @@ $root.vector_tile = (function() {
*/
var vector_tile = {};

/** @alias vector_tile.Tile */
vector_tile.Tile = (function() {

/**
Expand Down Expand Up @@ -166,7 +164,6 @@ $root.vector_tile = (function() {
POLYGON: 3
};

/** @alias vector_tile.Tile.Value */
Tile.Value = (function() {

/**
Expand Down Expand Up @@ -393,7 +390,6 @@ $root.vector_tile = (function() {
return Value;
})();

/** @alias vector_tile.Tile.Feature */
Tile.Feature = (function() {

/**
Expand Down Expand Up @@ -607,7 +603,6 @@ $root.vector_tile = (function() {
return Feature;
})();

/** @alias vector_tile.Tile.Layer */
Tile.Layer = (function() {

/**
Expand Down
2 changes: 0 additions & 2 deletions tests/data/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ var $lazyTypes = [];
// Exported root namespace
var $root = {};

/** @alias Package */
$root.Package = (function() {

/**
Expand Down Expand Up @@ -468,7 +467,6 @@ $root.Package = (function() {
/* eslint-enable */
})();

/** @alias Package.Repository */
Package.Repository = (function() {

/**
Expand Down
3 changes: 0 additions & 3 deletions tests/data/rpc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ var $lazyTypes = [];
// Exported root namespace
var $root = {};

/** @alias MyService */
$root.MyService = (function() {

/**
Expand Down Expand Up @@ -74,7 +73,6 @@ $root.MyService = (function() {
return MyService;
})();

/** @alias MyRequest */
$root.MyRequest = (function() {

/**
Expand Down Expand Up @@ -205,7 +203,6 @@ $root.MyRequest = (function() {
return MyRequest;
})();

/** @alias MyResponse */
$root.MyResponse = (function() {

/**
Expand Down
2 changes: 1 addition & 1 deletion types/protobuf.js.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// $> pbts --name protobufjs --out types/protobuf.js.d.ts src
// Generated Mon, 19 Dec 2016 22:48:40 UTC
// Generated Mon, 19 Dec 2016 23:08:18 UTC
declare module "protobufjs" {

/**
Expand Down

0 comments on commit 3e7e4fc

Please sign in to comment.