Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with 8.2 ArrayIterator interface updates #1987

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

oojacoboo
Copy link
Contributor

@oojacoboo oojacoboo commented Dec 11, 2023

ArrayIterator interface has gone with explicit true return values for sort methods. However, PHP less than 8.2 will crap out on this. We, instead, add the #[\ReturnTypeWillChange] attribute until we can make 8.2 the minimum supported version.

This replaces/closes #1984

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d22484) 89.28% compared to head (923c248) 89.28%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1987   +/-   ##
=========================================
  Coverage     89.28%   89.28%           
  Complexity     8058     8058           
=========================================
  Files           232      232           
  Lines         24534    24534           
=========================================
  Hits          21905    21905           
  Misses         2629     2629           
Flag Coverage Δ
5-max 89.28% <ø> (ø)
7.4 89.28% <ø> (ø)
agnostic 67.44% <ø> (ø)
mysql 69.83% <ø> (ø)
pgsql 69.87% <ø> (ø)
sqlite 67.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mringler
Copy link
Contributor

Hey @oojacoboo , have a look at d2bc7b8 for the current linter fix

@oojacoboo
Copy link
Contributor Author

@mringler yea, was looking at old logs and thinking it was still failing - fixed.

@PhilinTv PhilinTv self-assigned this Feb 4, 2024
@PhilinTv PhilinTv merged commit 6fd10bf into propelorm:master Feb 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants