Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken test on Postgres with PHP 8.2 #1980

Merged

Conversation

mringler
Copy link
Contributor

Fixes broken tests. Apparently, the order of retrieved objects has to be set, which makes sense. Curious though that the problem only started to appear just recently and only with Postgres on PHP 8.2.

Failed runs can be seen here and here

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4f36eea) 89.27% compared to head (bf3ebb5) 89.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1980   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
  Complexity     8049     8049           
=========================================
  Files           232      232           
  Lines         24519    24519           
=========================================
  Hits          21889    21889           
  Misses         2630     2630           
Flag Coverage Δ
5-max 89.27% <ø> (ø)
7.4 89.27% <ø> (ø)
agnostic 67.47% <ø> (ø)
mysql 69.81% <ø> (ø)
pgsql 69.83% <ø> (ø)
sqlite 67.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gechetspr gechetspr merged commit 8d22484 into propelorm:master Dec 7, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants