Fix mypy errors in testcommon py (pandas-dev#29179)

proost · Dec 19, 2019 · 768707a · 768707a
1 parent 34d42d2
commit 768707a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/pandas/tests/dtypes/test_common.py b/pandas/tests/dtypes/test_common.py
@@ -1,3 +1,5 @@
+from typing import List
+
 import numpy as np
 import pytest
 
@@ -322,9 +324,13 @@ def test_is_datetimelike():
     assert com.is_datetimelike(s)
 
 
+integer_dtypes = []  # type: List
+
+
 @pytest.mark.parametrize(
     "dtype",
-    [pd.Series([1, 2])]
+    integer_dtypes
+    + [pd.Series([1, 2])]
     + ALL_INT_DTYPES
     + to_numpy_dtypes(ALL_INT_DTYPES)
     + ALL_EA_INT_DTYPES
@@ -350,9 +356,13 @@ def test_is_not_integer_dtype(dtype):
     assert not com.is_integer_dtype(dtype)
 
 
+signed_integer_dtypes = []  # type: List
+
+
 @pytest.mark.parametrize(
     "dtype",
-    [pd.Series([1, 2])]
+    signed_integer_dtypes
+    + [pd.Series([1, 2])]
     + SIGNED_INT_DTYPES
     + to_numpy_dtypes(SIGNED_INT_DTYPES)
     + SIGNED_EA_INT_DTYPES
@@ -382,9 +392,13 @@ def test_is_not_signed_integer_dtype(dtype):
     assert not com.is_signed_integer_dtype(dtype)
 
 
+unsigned_integer_dtypes = []  # type: List
+
+
 @pytest.mark.parametrize(
     "dtype",
-    [pd.Series([1, 2], dtype=np.uint32)]
+    unsigned_integer_dtypes
+    + [pd.Series([1, 2], dtype=np.uint32)]
     + UNSIGNED_INT_DTYPES
     + to_numpy_dtypes(UNSIGNED_INT_DTYPES)
     + UNSIGNED_EA_INT_DTYPES

diff --git a/setup.cfg b/setup.cfg
@@ -136,9 +136,6 @@ ignore_errors=True
 [mypy-pandas.tests.arithmetic.test_datetime64]
 ignore_errors=True
 
-[mypy-pandas.tests.dtypes.test_common]
-ignore_errors=True
-
 [mypy-pandas.tests.extension.decimal.test_decimal]
 ignore_errors=True