Add givenIdentifier for feature generation

proophboard · Mar 28, 2024 · 4b9e886 · 4b9e886
1 parent 376f49c
commit 4b9e886
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/be/cucumber.js b/packages/be/cucumber.js
@@ -1,9 +1,10 @@
 // cucumber.js
 let common = [
   'features/**/*.feature',                // Specify our feature files
-  '--require-module ts-node/register', //typescript cucumber
-  '--require-module tsconfig-paths/register', //typescript cucumber
+  '--require-module ts-node/register', // typescript cucumber
+  '--require-module tsconfig-paths/register', // typescript cucumber
   '--require ./features/step_definitions/**/*.ts',   // Load step definitions
+  '--publish-quiet' // Remove publish message from output
 ].join(' ');
 
 process.env['NODE_ENV'] = "test";

diff --git a/.../src/lib/hooks/behaviour-test-files/features/step_definitions/__feature__Steps.ts__tmpl__ b/.../src/lib/hooks/behaviour-test-files/features/step_definitions/__feature__Steps.ts__tmpl__
@@ -35,7 +35,7 @@ class <%= feature %>Steps {
 
     let event = <%= givenEvent.propertyName %>(payload);
 
-    event = setMessageMetadata(event, AggregateMeta.ID, '<%= expectedIdentifier %>');
+    event = setMessageMetadata(event, AggregateMeta.ID, '<%= givenIdentifier %>');
     event = setMessageMetadata(event, AggregateMeta.TYPE, '<%= givenAggregateMetaType %>');
     event = setMessageMetadata(event, AggregateMeta.VERSION, 1);
 

diff --git a/packages/cody/src/lib/hooks/on-feature.ts b/packages/cody/src/lib/hooks/on-feature.ts
@@ -109,7 +109,6 @@ export const onFeature: CodyHook<Context> = async (feature: Node, ctx: Context)
 }
 
 async function createTestFiles(featureName: string, featureMeta: any, givenNodes : Array<Node>, whenCommand : Node, thenNodes : Array<Node>, ctx: Context): Promise<string> {
-  // if using a service from another board (e.g. Fleet Management), make sure to set this up in the test feature's metadata!
   const service = withErrorCheck(detectService, [whenCommand, ctx]);
 
   let aggregate: Node | undefined;
@@ -136,11 +135,10 @@ async function createTestFiles(featureName: string, featureMeta: any, givenNodes
   const syncedAggregate = withErrorCheck(getNodeFromSyncedNodes, [aggregate, ctx.syncedNodes]);
   const aggregateState = withErrorCheck(findAggregateState, [syncedAggregate, ctx]);
   const aggregateStateMeta = withErrorCheck(getVoMetadata, [aggregateState, ctx]);
-  const aggregateStateNames = names(aggregateState.getName());
+  const givenNodeDescriptionObject = JSON.parse('{'+givenNode.getDescription().replaceAll('\'', '"')+'}');
 
   const thenNode = thenNodes[0];
   const body = '{'+thenNode.getDescription().replaceAll('\'', '"')+'}';
-  console.log('Json body: '+ body);
   const thenNodeDescriptionObject = JSON.parse(body);
 
   const aggregateIdentifierProperty = aggregateStateMeta.identifier as keyof typeof thenNodeDescriptionObject;
@@ -156,6 +154,7 @@ async function createTestFiles(featureName: string, featureMeta: any, givenNodes
     "when": featureMeta[whenKey],
     "then": featureMeta[thenKey],
     "givenEvent": names(givenNode.getName()),
+    "givenIdentifier": givenNodeDescriptionObject[aggregateIdentifierProperty],
     "givenAggregateMetaType": givenAggregateMetaType,
     "whenEvent": names(whenCommand.getName()),
     "thenEvent": names(thenNodes[0].getName()),

diff --git a/...ges/contribution/src/generators/prepare-contribution/files/be/features/__tmpl__.gitignore b/...ges/contribution/src/generators/prepare-contribution/files/be/features/__tmpl__.gitignore
@@ -0,0 +1,2 @@
+*
+!tsconfig.json