This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Add idle metric #236
Merged
Add idle metric #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t value Signed-off-by: Cedric Nelson <cedric@lemony.ca>
Signed-off-by: Cedric Nelson <cedric@lemony.ca>
colakong
force-pushed
the
cnelson/add_idle_metric
branch
from
1e6131b
to
bd6cfc4
Compare
|
Thank you! |
matthiasr
added a commit
that referenced
this pull request
Feb 14, 2023
The official HAProxy exporter plugin uses `haproxy_process_idle_time_percent`, let's be consistent with that. Follow-up for #236. Signed-off-by: Matthias Rampke <matthias@prometheus.io>
This was referenced Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAProxy docs mention that the Idle_pct metric indicates how busy the event loop is; The closer to zero the value, the closer HAProxy is to its processing capacity.
This seems like a useful metric for capacity planning, so this PR is to include it metrics when scraping HAProxy via unix sockets.