Bump prometheus/client_golang to v0.9.2 #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
stuartnelson3
approved these changes
Dec 17, 2018
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Jan 14, 2019
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Go version (1.11.4) breaks the build process (reference: https://travis-ci.org/prometheus/alertmanager/builds/468643002) because it changes the checksum of the
github.com/prometheus/procfsmodule. Bumping prometheus/client_golang to v0.9.2 solves the issue because it uses Go modules which removesprocfsas an indirect dependency.See prometheus/blackbox_exporter#395 and golang/go#29278 (comment) for more details.