container: do not fail hard, if single containers can't be scraped #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
reviewed
Aug 14, 2024
|
This looks like it does the correct thing, can we run tests and see how its working? I don't have an environment to test things out right now but if someone does that would add some additional validation |
I would spawn the current released version this PR build together and check, if the values are equal at least. |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
… don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
… don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…ctors don't request any. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
|
Collected tested with |
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
astigmata
pushed a commit
to astigmata/windows_exporter
that referenced
this pull request
Sep 26, 2024
…rometheus-community#1561) Signed-off-by: astigmata <envoiici@gmail.com>
astigmata
pushed a commit
to astigmata/windows_exporter
that referenced
this pull request
Sep 26, 2024
…rometheus-community#1561) Signed-off-by: astigmata <envoiici@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1473