Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BlueprintSet #28

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Introduce BlueprintSet #28

merged 1 commit into from
Jul 29, 2023

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Jul 28, 2023

This change requires bevyengine/bevy#9260 Will work without it, but there will still be a one frame delay for scenes until the mentioned PR is merged.

@Shatur Shatur changed the title Run parent sync after scene spawn Introduce BlueprintSet Jul 29, 2023
@Shatur Shatur marked this pull request as ready for review July 29, 2023 10:19
@Shatur Shatur force-pushed the parent-sync-scene branch 2 times, most recently from 5addb03 to b662314 Compare July 29, 2023 10:23
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (9d0c102) 94.92% compared to head (f8467be) 94.97%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   94.92%   94.97%   +0.04%     
==========================================
  Files          12       12              
  Lines         709      716       +7     
==========================================
+ Hits          673      680       +7     
  Misses         36       36              
Files Changed Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/parent_sync.rs 92.30% <100.00%> (+1.00%) ⬆️
src/replication_core.rs 91.80% <100.00%> (+0.57%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit 6f53149 into master Jul 29, 2023
4 checks passed
@Shatur Shatur deleted the parent-sync-scene branch July 29, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants