Use Router in Trusted Database #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
approved these changes
Nov 20, 2020
docs/programming-oak.md
Outdated
| @@ -407,13 +407,17 @@ associated type to | |||
| or manually reading from the initial `Receiver`: | |||
There was a problem hiding this comment.
Could you update this doc? I think we don't need to mention the initial Receiver any more, all nodes are expected to impl CommandHandler now.
There was a problem hiding this comment.
Deleted or manually reading from the initial Receiver
| log_sender: Some(self.log_sender.clone()), | ||
| points_of_interest: Some(self.points_of_interest.clone()), | ||
| }; | ||
| let handler_invocation_sender = |
There was a problem hiding this comment.
Maybe add some comments to explain the logic here.
There was a problem hiding this comment.
Added a comment for impl CommandHandler for Router
rbehjati
approved these changes
Nov 20, 2020
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index ffd3c31..1b59d32 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,11 +1,11 @@
-15030ecb052d10488df515d77a8628686099ed471d984bab327c5b0cc02c450b ./examples/target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
-cfbe0188f6b88dfac9839a0d0affb0ce774b3bbb962145032170029c18448978 ./examples/target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
-ae3886c1faa30c272eddafffbeb2fb25344a99b59ed76a693be6ce2f7da2af63 ./examples/target/wasm32-unknown-unknown/release/aggregator.wasm
-15dad108de55453f98be4fc626b79235ba01846305d3adce9f515c8fb67ea0ad ./examples/target/wasm32-unknown-unknown/release/chat.wasm
-972fac1b756f548f8ba4cd1531773bbcbe7605d2923a1174d04e1d81fde5fff3 ./examples/target/wasm32-unknown-unknown/release/hello_world.wasm
-f640e15c38a7df382d88fe1f1744257d370cdbfcc6f9d06f18a38e2689e44bc1 ./examples/target/wasm32-unknown-unknown/release/http_server.wasm
-dfd2bf7813c1e60513243adc773fb67db8d8e5fc23d6f5937e83a1ba9dfa8511 ./examples/target/wasm32-unknown-unknown/release/injection.wasm
-102d95b26c00154407dd6278cde0653af1c69f77f4f6df72896872280a605c1a ./examples/target/wasm32-unknown-unknown/release/private_set_intersection.wasm
-90b4bb4e4d13a0c3b9002d8e3ce77692020dd31bfa97b0a65ec971b7efbf5b04 ./examples/target/wasm32-unknown-unknown/release/translator.wasm
-630e82dd05bdb4c9a7b075a5aaad180d12b6f435032bc9cb728cbeaf61a58596 ./examples/target/wasm32-unknown-unknown/release/trusted_database.wasm
-abff22923e25a008ab3f442e8e047eb862ee19cdafb7704e5bd9fb322e26492f ./oak_loader/target/x86_64-unknown-linux-musl/release/oak_loader
+a26d098554bef31a5d0339567f78cdc03e5ca339c28db447733234d560ed1aed ./examples/target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
+fc05912ce96279ab634b3d9a840785beff525f470b7ecad8464a5759468ae101 ./examples/target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
+d6e2d8870f0e15c158a96fff400e569360afd9895a796ddde544691c2370911f ./examples/target/wasm32-unknown-unknown/release/aggregator.wasm
+51fb2b3adc5614c86c4909633daf36e28e6bf4a49f3871530ecb07956d14a842 ./examples/target/wasm32-unknown-unknown/release/chat.wasm
+b1258cf2c7e0fa80460129f4a451d7487615a92f79937eecc1c65972652176c6 ./examples/target/wasm32-unknown-unknown/release/hello_world.wasm
+2067a83188f4f229f4c2c4c1ea910dcf83247e727421dfc562b1a5ed42825514 ./examples/target/wasm32-unknown-unknown/release/http_server.wasm
+c258f27cfb2792308579cda9bbd2725c84e4a625474ac1254f6396cedd6c65ab ./examples/target/wasm32-unknown-unknown/release/injection.wasm
+9cf8c07839bddf90540de2d46d4170607f38d41ee252c63612711ece84d1c3d6 ./examples/target/wasm32-unknown-unknown/release/private_set_intersection.wasm
+5894508da77351ffd4185f26a932827a8c0b913d50a2e252f503ef3b30fb78f3 ./examples/target/wasm32-unknown-unknown/release/translator.wasm
+60c2e8e5e8001302a9311f1b6472a6ff3f4df8e25c55ab1053dee4a91dbd5b1f ./examples/target/wasm32-unknown-unknown/release/trusted_database.wasm
+357cf658223907795a4dbf1a9b710f23c4f9c9a7a54cfdf4153c9f3b6edb3a83 ./oak_loader/target/x86_64-unknown-linux-musl/release/oak_loader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates Trusted Database example to use Router pattern.
Ref #1066