Use signature label in Private Set Intersection #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiziano88 since we will not add Wasm signature labels to TIR, but still need an example with it for CI, what could be a better choice for it? |
|
Yes I agree, I think that's a good fit |
ipetr0v
force-pushed
the
tir_signature_label
branch
from
edd565b
to
a27b163
Compare
ipetr0v
changed the title
ipetr0v
force-pushed
the
tir_signature_label
branch
from
6a5ff47
to
1fb4020
Compare
tiziano88
approved these changes
Sep 8, 2020
examples/private_set_intersection/client/private_set_intersection.cc
Outdated
Show resolved
Hide resolved
Comment on lines
6
to
7
| z/qheXvmNUY/1YY06sw+1KQ0KjD9JF3/8aXHn9M8QtjTl0VY8rHWhnrWsWFiPmMG | ||
| Ee7ZndTs3yVQRUIa7BMoBg== |
There was a problem hiding this comment.
Out of curiosity, if you re-sign the same file with the same key, does it produce the same signature? Or does it use some nondeterministic value as part of the signature?
There was a problem hiding this comment.
I regenerated a signature, and it stays the same
ipetr0v
force-pushed
the
tir_signature_label
branch
from
1fb4020
to
690373f
Compare
tiziano88
approved these changes
Sep 8, 2020
examples/private_set_intersection/client/private_set_intersection.cc
Outdated
Show resolved
Hide resolved
Move signature label from TIR to PSI Fix signature discovery Fix signature Fix tests
ipetr0v
force-pushed
the
tir_signature_label
branch
from
690373f
to
86a11a9
Compare
rbehjati
approved these changes
Sep 9, 2020
examples/private_set_intersection/client/private_set_intersection.cc
Outdated
Show resolved
Hide resolved
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 2c56734..26afeb5 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -11,4 +11,4 @@ c1fae198b82f6000debf3bb66cd90566628d693c89f02ea9ac9de37acaa4a86a ./examples/tar
ecff5e62c1f2b1ac04e76dfae01e56b7fb3c595cc293d21ac0bbe9fa26cf18c8 ./examples/target/wasm32-unknown-unknown/release/running_average.wasm
61229225a8ba24e262d82c42ed761e125b187bbdf4cac32f8f68c4e888210171 ./examples/target/wasm32-unknown-unknown/release/translator.wasm
605884919eb59517cca5e4678800b9c001eb6ab82a01a8f76be11d6156a9637a ./examples/target/wasm32-unknown-unknown/release/trusted_information_retrieval.wasm
-977b0a655338ae75fa445e6cacdb48ff26313f6c87f31817a63dac9e1a850611 ./oak_loader/target/x86_64-unknown-linux-musl/release/oak_loader
+893348254c1193ad902e64a32b8db3a05c8397c8fdc7293900fe3d8843ec44ba ./oak_loader/target/x86_64-unknown-linux-musl/release/oak_loader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a signature label to Private Set Intersection example.
Fixes #1344
Ref #1066
Checklist