Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5425] Fix regression with false unleash flag #5266

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Aug 21, 2024

Jira Ticket

COST-4907

Description

This change will fix a regression for when the unleash flag is false.

Testing

Set the unattributed_storage param to false in the populate_ocp_on_aws_cost_daily_summary_trino method and hit resummary

sql_params = {
            "schema": self.schema,
            "start_date": start_date,
            "year": year,
            "month": month,
            "days": days_tup,
            "end_date": end_date,
            "aws_source_uuid": aws_provider_uuid,
            "ocp_source_uuid": openshift_provider_uuid,
            "bill_id": bill_id,
            "report_period_id": report_period_id,
            "markup": markup_value or 0,
            "pod_column": pod_column,
            "node_column": node_column,
            "unattributed_storage": False,
        }

Release Notes

  • proposed release note
* [COST-5425](https://issues.redhat.com/browse/COST-5425) Fix regression with false unleash flag

@myersCody myersCody added the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label Aug 21, 2024
@myersCody myersCody self-assigned this Aug 21, 2024
@myersCody myersCody requested review from a team as code owners August 21, 2024 12:57
@myersCody myersCody enabled auto-merge (squash) August 21, 2024 13:00
@myersCody myersCody changed the title [COST-4907] Fix regression with false unleash flag [COST-5425] Fix regression with false unleash flag Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (27b952a) to head (5930b17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5266   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        375     375           
  Lines      31429   31429           
  Branches    4627    4627           
=====================================
+ Hits       29572   29575    +3     
+ Misses      1187    1184    -3     
  Partials     670     670           

@myersCody myersCody merged commit bfdfecc into main Aug 21, 2024
11 checks passed
@myersCody myersCody deleted the fix_false_condition_cost_4907 branch August 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants