[COST-4907] Add temp table to track aws disk capacities #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myersCody
added
the
aws-smoke-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 375 375
Lines 31422 31429 +7
Branches 4627 4627
=======================================
+ Hits 29564 29570 +6
- Misses 1187 1188 +1
Partials 671 671 |
maskarb
reviewed
Aug 20, 2024
| @@ -162,6 +162,19 @@ CREATE TABLE IF NOT EXISTS hive.{{schema | sqlsafe}}.reporting_ocpawscostlineite | |||
| ) WITH(format = 'PARQUET', partitioned_by=ARRAY['aws_source', 'ocp_source', 'year', 'month', 'day']) | |||
| ; | |||
|
|
|||
| {% if unattributed_storage %} | |||
There was a problem hiding this comment.
Do we need to disable table creation? We didn't for Azure, I don't think.
There was a problem hiding this comment.
I put it behind unleash for now so that there is flexibility to add another column if needed later on in the process without having to run a trino migration. If it is a blocker I can remove the if though.
maskarb
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4907
Description
This change will add a temporary table for tracking aws disk capacities.
Testing
Example return:
Release Notes