Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5161] - Drop Azure v1 support #5245

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Aug 2, 2024

Jira Ticket

COST-5161

Description

This change will drop Azure v1 cotst export support

We need to follow up with removing all the old code but this will prevent us processing old reports.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. create Azure source
  4. Ingest report using V2
  5. Everything should process correctly
  6. ingest Azure V1 report
  7. A warning message should pop up and processing will halt

Release Notes

  • proposed release note
* [COST-5161](https://issues.redhat.com/browse/COST-5161) Drop support for Azure v1 reports

@lcouzens lcouzens added the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label Aug 2, 2024
@lcouzens lcouzens requested review from a team as code owners August 2, 2024 20:06
@lcouzens lcouzens added the full-run-smoke-tests pr_check will build the image and run all smoke tests label Aug 5, 2024
bacciotti
bacciotti previously approved these changes Aug 5, 2024
@lcouzens lcouzens removed the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label Aug 5, 2024
@lcouzens
Copy link
Contributor Author

lcouzens commented Aug 5, 2024

/retest

1 similar comment
@lcouzens
Copy link
Contributor Author

lcouzens commented Aug 5, 2024

/retest

@lcouzens lcouzens enabled auto-merge (squash) August 5, 2024 12:36
@lcouzens
Copy link
Contributor Author

lcouzens commented Aug 5, 2024

Full smokes had the following failures:

test_api_cost_model_ocp_cost_distribution_node_cpu_values
test_api_cost_model_ocp_cost_distribution_project_cpu_values
test_api_cost_model_ocp_cost_distribution_update_values

Not sure these are related to the changes in this PR.

@lcouzens lcouzens added smoke-tests pr_check will build the image and run minimal required smokes and removed full-run-smoke-tests pr_check will build the image and run all smoke tests labels Aug 5, 2024
@lcouzens lcouzens disabled auto-merge August 5, 2024 12:45
@lcouzens lcouzens enabled auto-merge (squash) August 5, 2024 13:15
@lcouzens lcouzens added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3d79211) to head (ca845a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5245     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        375     375             
  Lines      31410   31416      +6     
  Branches    4623    4625      +2     
=======================================
  Hits       29551   29551             
- Misses      1185    1186      +1     
- Partials     674     679      +5     

@lcouzens lcouzens merged commit 35f32e9 into main Aug 5, 2024
11 checks passed
@lcouzens lcouzens deleted the COST-5161-drop-v1-support branch August 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants