-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5161] - Drop Azure v1 support #5245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcouzens
added
the
azure-smoke-tests
pr_check will build the image and run azure + ocp on azure smoke tests
label
Aug 2, 2024
lcouzens
added
the
full-run-smoke-tests
pr_check will build the image and run all smoke tests
label
Aug 5, 2024
bacciotti
previously approved these changes
Aug 5, 2024
lcouzens
removed
the
azure-smoke-tests
pr_check will build the image and run azure + ocp on azure smoke tests
label
Aug 5, 2024
/retest |
1 similar comment
/retest |
Full smokes had the following failures:
Not sure these are related to the changes in this PR. |
lcouzens
added
smoke-tests
pr_check will build the image and run minimal required smokes
and removed
full-run-smoke-tests
pr_check will build the image and run all smoke tests
labels
Aug 5, 2024
lcouzens
force-pushed
the
COST-5161-drop-v1-support
branch
from
August 5, 2024 13:53
15b147d
to
4d97e8e
Compare
lcouzens
added
hot-fix-smoke-tests
pr_check label to run minimal smoke tests for fast moving bug-fix
and removed
smoke-tests
pr_check will build the image and run minimal required smokes
labels
Aug 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5245 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 375 375
Lines 31410 31416 +6
Branches 4623 4625 +2
=======================================
Hits 29551 29551
- Misses 1185 1186 +1
- Partials 674 679 +5 |
bacciotti
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hot-fix-smoke-tests
pr_check label to run minimal smoke tests for fast moving bug-fix
smokes-required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5161
Description
This change will drop Azure v1 cotst export support
We need to follow up with removing all the old code but this will prevent us processing old reports.
Testing
Release Notes