Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5288] Fix currency for network distribution #5223

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Jul 18, 2024

Jira Ticket

COST-5288

Description

This change will fix currency exchange for network distribution

Testing

Release Notes

  • proposed release note
* [COST-5288](https://issues.redhat.com/browse/COST-5288) Use correct currency when calculating network unattributed cost

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (6ffdd28) to head (26cdf30).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5223   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        373     373           
  Lines      31136   31136           
  Branches    4574    4574           
=====================================
+ Hits       29305   29306    +1     
+ Misses      1165    1164    -1     
  Partials     666     666           

@samdoran samdoran added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 22, 2024
@myersCody myersCody added azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests and removed azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests labels Jul 22, 2024
@myersCody myersCody marked this pull request as ready for review July 23, 2024 17:42
@myersCody myersCody requested review from a team as code owners July 23, 2024 17:42
@myersCody myersCody enabled auto-merge (squash) July 23, 2024 17:43
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody merged commit ae74f10 into main Jul 23, 2024
11 checks passed
@myersCody myersCody deleted the cost-5288-network-currency-distribution branch July 23, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants