Adding offsetof checks as static assertions when refining a C type #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikswamy
commented
Aug 20, 2024
| then false | ||
| else let suffix' = String.sub s (l - sl) sl in | ||
| suffix = suffix' | ||
|
|
nikswamy
commented
Aug 20, 2024
| offsets |> | ||
| List.collect | ||
| (fun offset -> | ||
| if TypeSizes.is_alignment_field (fst offset) |
There was a problem hiding this comment.
Exclude assertions on fields that are added for alignment padding; they are implicit in the C type
nikswamy
commented
Aug 20, 2024
| let ds = List.map (decl_size_with_alignment env) ds in | ||
| let ge = B.global_env_of_env (fst env) in | ||
| ds |> List.iter (fun d -> |
There was a problem hiding this comment.
Update the global environment with revised type declarations after fields (may) have been added for alignment padding
nikswamy
commented
Aug 20, 2024
| #ifndef C_ASSERT | ||
| #define C_ASSERT(e) typedef char __C_ASSERT__[(e)?1:-1] | ||
| #endif | ||
| typedef char CIRCLE[20]; |
There was a problem hiding this comment.
Revise the test case, since we now also check offsets, not just sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. Issue #143