Updating dotdot loader #1432
Merged
Updating dotdot loader #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhchandw
force-pushed
the
task/unifyWorkaround
branch
from
8f04e14
to
33dd5bd
Compare
brdandu
requested changes
Sep 24, 2024
| @@ -456,10 +456,11 @@ function prepareCluster(cluster, types, isExtension = false) { | |||
| */ | |||
| function prepareAtomic(type) { | |||
| let desc = type.$.name | |||
| let length = type.restriction?.[0]?.['type:length']?.[0]?.$?.value | |||
There was a problem hiding this comment.
This is pretty complicated.
There was a problem hiding this comment.
Due to the format of the XML object this is how deep the length property is. Would you suggest creating a helper for this?
| a.name.endsWith('u') || | ||
| !a.name.includes('int') | ||
| ? 0 | ||
| : 1, |
There was a problem hiding this comment.
Do we do something similar on the zcl-loader-silabs?
There was a problem hiding this comment.
XMLs loaded through zcl-loader-silabs (Matter/Zigbee) expect the isSigned field to be specified in the XML. If not they do some regex matching - /^int[0-9]{1,2}s?$/.test(a.$.name).
dhchandw
force-pushed
the
task/unifyWorkaround
branch
from
33dd5bd
to
3326112
Compare
* making sure discriminator ref is set correctly for all strings * making sure is_signed is set correctly for all numbers * dealing with subatomics (by processing them last) * picking up atomic size from length property fixing incorrect value in zcl-loader-consecutive.test.js and adding string count test in zcl-loader.test.js
dhchandw
force-pushed
the
task/unifyWorkaround
branch
from
3326112
to
61a5478
Compare
brdandu
approved these changes
Sep 25, 2024
paulr34
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
zcl-loader-dotdot.js:making sure discriminator ref is set correctly for all strings
making sure is_signed is set correctly for all numbers
dealing with subatomics (by processing them last)
picking up atomic size from length property
fixing incorrect value in
zcl-loader-consecutive.test.jsand adding string count test tozcl-loader.test.js