dynamically enabling Matter/Zigbee only components for CMP #1427
Conversation
| @@ -90,7 +90,7 @@ export default { | |||
| return this.enableMatterFeatures | |||
| }, | |||
| enableServerOnly() { | |||
| return this.enableMatterFeatures && !this.enableZigbeeFeatures | |||
There was a problem hiding this comment.
What about client clusters which belong to endpoints with Zigbee's zcl device types? Those should still be configurable.
There was a problem hiding this comment.
yes it appears there is a bigger problem here
There was a problem hiding this comment.
Does this change not disable Zigbee client cluster configuration?
There was a problem hiding this comment.
it does not disable it
There was a problem hiding this comment.
to be clear, ZAP master branch, as of now, when running CMP mode never distinguishes between Zigbee and Matter. That logic is broken. So this PR fixes that.
There was a problem hiding this comment.
Add cypress tests to make sure that client clusters of zigbee endpoint is still configurable but not matter endpoints in the case of CMP.
There was a problem hiding this comment.
we do not have the framework to make Zigbee or matter specific cypress tests, do you think that should block this?
There was a problem hiding this comment.
we definitely need cypress tests you're right!
There was a problem hiding this comment.
Maybe you know, but I had started to implement a solution for detecting zigbee and matter cases in cypress. It has not been finished yet but it is working now. So we have an attribute that helps me detect which mode is active in the Cypress test. This is the "mode" attribute.
cy.fixture('data').then((data) => { if(data.mode === 'matter') { //code } if(data.mode === 'zigbee') { //code } })
paulr34
changed the title
| @@ -415,9 +415,7 @@ export default { | |||
| sortBy: 'clientServer' | |||
| }, | |||
| columns: [], | |||
| forcedExternal: [], | |||
| enableSingleton: false, | |||
| enableBounded: false | |||
There was a problem hiding this comment.
why are attribute manager settings changed?
There was a problem hiding this comment.
because that code is out of date with the changes to ui-options.js
| @@ -90,7 +90,7 @@ export default { | |||
| return this.enableMatterFeatures | |||
| }, | |||
| enableServerOnly() { | |||
| return this.enableMatterFeatures && !this.enableZigbeeFeatures | |||
There was a problem hiding this comment.
Does this change not disable Zigbee client cluster configuration?
There was a problem hiding this comment.
I am confused. Which JIRA or Github issue is this solving?
There was a problem hiding this comment.
there is no ticket for this because while I was solving the 1499 I noticed the whole thing was broken
CMP components cacheing