Update to node v20 for ZAP (#1419)

* Update to node v20 for ZAP
- Update all workflows to use node v20
- Update documentation about using node v20
- JIRA: ZAPP-1494

* Minor cleanup

.github/workflows/matter.yml

@@ -24,7 +24,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:
@@ -67,7 +67,7 @@ jobs:
       - name: Install Node.js, NPM and Yarn
         uses: actions/setup-node@v3.0.0
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: 'npm'
 
       - name: Prepare Linux build environment
@@ -188,7 +188,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
 
     # CHIP container required because clang-format version needs to match
     container:

.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:
@@ -52,7 +52,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:
@@ -81,7 +81,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:
@@ -120,7 +120,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:
@@ -158,7 +158,7 @@ jobs:
       - name: Install Node.js, NPM and Yarn
         uses: actions/setup-node@v3.0.0
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: 'npm'
       - name: pip
         run: pip install setuptools

.github/workflows/unify.yml

@@ -24,7 +24,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:

.github/workflows/zigbee.yml

@@ -24,7 +24,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [ubuntu-22.04]
 
     steps:

docs/ZAP-on-Windows.md

@@ -82,6 +82,6 @@ npm run build
 
 ### 4. Other
 
-Check if node version is v18, and try to install it with Chocolatey
+Check if node version is v20, and try to install it with Chocolatey
 
 Also, you can check the faq doc for other known issues: https://github.com/project-chip/zap/blob/master/docs/faq.md

docs/development-instructions.md

@@ -2,7 +2,7 @@
 
 This section lists instructions for various things you might need to do in this repo.
 
-This is a node.js application, so you need node environment installed. The best way is to simply download latest install of [node](https://nodejs.org/en/download/) and you will get node and npm. If you have an older version of node installed on your workstation, it may give you trouble, particularly if it's very old. So make sure you have latest node v16.x version, with the npm that comes with it available. Run `node --version` to check what version is picked up. v18.x is recommended.
+This is a node.js application, so you need node environment installed. The best way is to simply download latest install of [node](https://nodejs.org/en/download/) and you will get node and npm. If you have an older version of node installed on your workstation, it may give you trouble, particularly if it's very old. So make sure you have latest node v16.x, v18.x or v20.x version, with the npm that comes with it available. Run `node --version` to check what version is picked up. v20.x is recommended.
 
 Once you have a desired version of node, you can run:
 

src-electron/util/env.js

@@ -556,7 +556,7 @@ export function isMatchingVersion(versionsArray, providedVersion) {
  * @returns true or false, depending on match
  */
 export function versionsCheck() {
-  let expectedNodeVersion = ['v14.x.x', 'v16.x.x', 'v18.x.x']
+  let expectedNodeVersion = ['v14.x.x', 'v16.x.x', 'v18.x.x', 'v20.x.x']
   let expectedElectronVersion = [
     '17.4.x',
     '18.x.x',