[TC-IDM-4.3] Report Data Messages post Subscription Activation (python) #33477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raul-marquez-csa
changed the title
|
PR #33477: Size comparison from 1b455b5 to 640286b Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33477: Size comparison from 1b455b5 to 68f3b6a Increases (1 build for linux)
Decreases (5 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33477: Size comparison from 3c6bd79 to 8356a27 Full report (18 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32)
|
|
PR #33477: Size comparison from 244fd8c to 078ed6b Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…nectedhomeip into tc-idm-4.3-(python)
|
PR #33477: Size comparison from eb515e1 to 2ba8359 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33477: Size comparison from b398fb4 to 985e53a Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…porary debug logging
|
PR #33477: Size comparison from 8fa5422 to 759dd8c Increases (9 builds for cyw30739, linux, telink)
Decreases (2 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33477: Size comparison from 32a84b4 to 3eee95e Increases (9 builds for cyw30739, linux, telink)
Decreases (2 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…nectedhomeip into tc-idm-4.3-(python)
|
PR #33477: Size comparison from 32a84b4 to 7674e43 Increases (9 builds for cyw30739, linux, telink)
Decreases (2 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33477: Size comparison from 32a84b4 to e566592 Increases above 0.2%:
Increases (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33477: Size comparison from 20b1457 to ce9f2a0 Increases (8 builds for cyw30739, linux)
Decreases (1 build for linux)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, psoc6, qpg, stm32)
|
…nectedhomeip into tc-idm-4.3-(python)
|
PR #33477: Size comparison from 71d9f61 to 400c38f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jul 3, 2024
| @@ -745,9 +755,9 @@ def handleResubscriptionAttempted(self, terminationCause: PyChipError, nextResub | |||
| def _handleReportBegin(self): | |||
| pass | |||
|
|
|||
| def _handleReportEnd(self): | |||
| def _handleReportEnd(self): | |||
There was a problem hiding this comment.
Suggested change
| def _handleReportEnd(self): | |
| def _handleReportEnd(self): |
There was a problem hiding this comment.
Basically, you'll need to fix the linter comments.
| if self._notify_subscription_still_active_callback: | ||
| self._notify_subscription_still_active_callback() | ||
|
|
||
| def handleNotifySubscriptionStillActive(self): |
There was a problem hiding this comment.
I know you're just following the current pattern, but ...why does this just redirect to an internal function?
| def handleReportBegin(self): | ||
| pass | ||
|
|
||
| self._handleReportBegin() |
There was a problem hiding this comment.
suggest removing - this doesn't do anything.
|
|
||
| class TC_IDM_4_3(MatterBaseTest): | ||
|
|
||
| # ANSI escape codes for background colors |
There was a problem hiding this comment.
Please omit the color printing - not sure what this will do in the TH
|
|
||
| def wait_for_attribute_update_report(self, expected_attribute, output): | ||
| try: | ||
| path, transaction = output.get(block=True, timeout=10) |
There was a problem hiding this comment.
where does the 10 come from?
src/python_testing/TC_IDM_4_3.py
Outdated
|
|
||
| sub_th_step1ab.SetNotifySubscriptionStillActiveCallback(self.on_notify_subscription_still_active) | ||
|
|
||
| secs = 15 |
|
|
||
| asserts.assert_equal(path.AttributeType, self._expected_attribute, | ||
| f"[AttributeChangeCallback] Attribute mismatch. Expected: {self._expected_attribute}, received: {path.AttributeType}") | ||
| logging.info(f"[AttributeChangeCallback] Attribute update callback for {path.AttributeType}") |
There was a problem hiding this comment.
please remove the log - this could get a bit chatty. Or set to debug.
|
PR #33477: Size comparison from 7dd6b4b to f68d2e8 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #33477: Size comparison from 20d6857 to e635865 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33477: Size comparison from 1e58f96 to 38fba93 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33477: Size comparison from a902838 to 74c170c Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33477: Size comparison from a902838 to 0251902 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33477: Size comparison from a902838 to 9f262a3 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Functional
Description:
This test case will verify the report data messages sent from the DUT after activating
subscription are according to specification.
Full test plan link for details:
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/interactiondatamodel.adoc#443-tc-idm-43-report-data-messages-post-subscription-activation-from-dut-test-cases-dut_server