-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chiptool.py] Remove the dot in the cluster name for the chip-tool ad… #27260
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipToolPy_RemoveDotInTheClusterName
Jun 15, 2023
Merged
[chiptool.py] Remove the dot in the cluster name for the chip-tool ad… #27260
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipToolPy_RemoveDotInTheClusterName
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apter before sending it over the wire
jmeg-sfy
approved these changes
Jun 15, 2023
mhazley
approved these changes
Jun 15, 2023
PR #27260: Size comparison from 2eef730 to a206112 Increases (6 builds for psoc6, telink)
Decreases (11 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
p0fi
approved these changes
Jun 15, 2023
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/encoder.py
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jun 15, 2023
bzbarsky-apple
approved these changes
Jun 15, 2023
PR #27260: Size comparison from a870765 to b2a42bc Increases (10 builds for bl602, cc32xx, efr32, psoc6, telink)
Decreases (11 builds for cyw30739, esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…apter before sending it over the wire
Problem
For YAML tests running with the
matter_yamltests
backend, if a cluster name contains a "." it is not removed before beeing sent tochip-tool
.A workaround is to remove the dot in the yaml file, but it first requires the name to be different from the one in the spec, and it also prevents the python backend to properly resolve the cluster and tells the user about possible mistakes I the test.