Stop generating BridgeGlobalStructs.h for dynamic-bridge-app #27020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
bzbarsky-apple
approved these changes
Jun 1, 2023
|
PR #27020: Size comparison from 28e0423 to 675091d Increases (2 builds for bl602, bl702)
Decreases (11 builds for bl602, bl702, cc32xx, cyw30739, linux, mbed, psoc6)
Full report (31 builds for bl602, bl702, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6)
|
tcarmelveilleux
approved these changes
Jun 1, 2023
tcarmelveilleux
approved these changes
Jun 1, 2023
|
PR #27020: Size comparison from 28e0423 to afed3b6 Increases (7 builds for bl702, esp32, telink)
Decreases (8 builds for bl602, bl702, cc32xx, linux, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hicklin
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic bridge does not fully support all types of structures. In general it tries to use C++ standard structs (std::vector and std::string) and does not support all types.
When looking at #26508 I found that:
known types(like vendor_id mapping to chip::VendorId). This is fixable by logic like https://github.com/project-chip/connectedhomeip/blob/master/scripts/py_matter_idl/matter_idl/generators/java/__init__.py#L103 )std::vectorandDecodableListwas not doneThe last change felt like too much yak-shaving, so instead of trying to fix dynamic bridge for all possible future global structs, I just stop using global structures as currently structures appear both globally and per-cluster and most codegen only assumes per-cluster types.
This does mean that dynamic bridge will NOT support all clusters possible without fixes (in particular modeselect will not work) however thosefixes should be applied by anyone trying to maintain dynamic bridge.