-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin-framework-tool] Do not build Matter SDK twice when config_enable_yaml_tests=false #23682
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_DoNotBuildMatterSDKTwiceWhenTestAreDisabled
Dec 2, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23682: Size comparison from 287c1b5 to c937c04 Increases (10 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
c937c04
to
28c1ea3
Compare
PR #23682: Size comparison from 494f5f5 to 28c1ea3 Increases (5 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 29, 2022
bzbarsky-apple
approved these changes
Nov 30, 2022
…ble_yaml_tests=false
28c1ea3
to
15bd488
Compare
PR #23682: Size comparison from f9d9457 to 15bd488 Increases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl602, bl702, linux, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
./scripts/examples/gn_build_example.sh examples/darwin-framework-tool out/debug/standalone
results into building the Matter SDK twice. Once because somedarwin-framework-tool
dependencies pulls in the Matter SDK and one because ofMatter.framework
. Worst, the 2 versions of the SDK can be built with different flags which introduce strange behaviour whenMatter.framework
is statically linked.This PR update
examples/darwin-framework-tool
such that addingconfig_enable_yaml_tests=false
does results into a single copy of the SDK.In a future patch, I'm planning to update
chip-tool
anddarwin-framework-tool
to not have to pull in dependencies fromsrc/app/tests/suites
in order to runs the tests which should make it fine all the time. But this is a non-negligeable amount of work and this is out of the scope of this PR which is to allowdarwin-framework-tool
to not creates an extra copy of the SDK.