Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Fix Reads + Misc Fixes #11878

Merged
merged 5 commits into from
Nov 20, 2021
Merged

Python: Fix Reads + Misc Fixes #11878

merged 5 commits into from
Nov 20, 2021

Conversation

mrjerryjohns
Copy link
Contributor

This PR fixes the following:

  • When handing a buffer of bytes from C++ to Python, the usage of
    c_char_p instead of c_void_p resulted in the buffer being treated as a
    null-terminated string, resulting in the clipping of the data anytime
    zero was encountered. This resulted in reads not quite working.

  • Fixed up the logic that automatically looked up the right type of
    cluster object when processing a read response.

  • Simplified the API for WriteAttribute by converting the generated
    classes for attributes into dataclasses with a 'value' member in them.

  • Added Python docstrings for read and write APIs

@mrjerryjohns
Fix Reads + Misc Fixes
70d9c3e 
This PR fixes the following:

- When handing a buffer of bytes from C++ to Python, the usage of
 c_char_p instead of c_void_p resulted in the buffer being treated as a
 null-terminated string, resulting in the clipping of the data anytime
 zero was encountered. This resulted in reads not quite working.

- Fixed up the logic that automatically looked up the right type of
  cluster object when processing a read response.

- Simplified the API for WriteAttribute by converting the generated
  classes for attributes into dataclasses with a 'value' member in them.

- Added Python docstrings for read and write APIs
@mrjerryjohns mrjerryjohns changed the title Fix Reads + Misc Fixes Python: Fix Reads + Misc Fixes Nov 16, 2021
@andy31415
Copy link
Contributor

fast track: python only changes made by a domain owner.

@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11878: Size comparison from 5a06fce to 70d9c3e

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5a06fce 70d9c3e change % change
efr32 lighting-app BRD4161A (read only) 745208 745208 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745200 745200 0 0.0
BRD4161A+rpc (read only) 732724 732724 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732716 732716 0 0.0
lock-app BRD4161A (read only) 722296 722296 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722288 722288 0 0.0
window-app BRD4161A (read only) 723272 723272 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 723264 0 0.0
esp32 all-clusters-app c3devkit (read only) 824912 824912 0 0.0
(read/write) 1219650 1219650 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163800 0 0.0
.flash.text 824912 824912 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895819 0 0.0
(read/write) 418980 418980 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191780 0 0.0
.flash.text 890435 890435 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703576 703576 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 618876 0 0.0
lock-app k32w061+debug (read/write) 595020 595020 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 519840 0 0.0
shell k32w061+debug (read/write) 660252 660252 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574040 0 0.0
linux all-clusters-app debug (read only) 1701841 1701841 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135253 0 0.0
.text 1433138 1433138 0 0.0
bridge-app debug+rpc (read only) 1297013 1297013 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110668 0 0.0
.text 1089445 1089445 0 0.0
chip-tool debug (read only) 4950077 4950077 0 0.0
(read/write) 166376 166376 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118016 118016 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265778 265778 0 0.0
.text 4375157 4375157 0 0.0
lighting-app debug+rpc (read only) 1566073 1566073 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128273 0 0.0
.text 1303298 1303298 0 0.0
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1042386 1042386 0 0.0
ota-requestor-app debug (read only) 1335553 1335553 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123920 123920 0 0.0
.text 1112210 1112210 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1839065 1839065 0 0.0
(read/write) 405016 405016 0 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155277 155277 0 0.0
.text 1539522 1539522 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2283728 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246328 1246328 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2269720 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232320 1232320 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2245560 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208160 1208160 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860183 0 0.0
bss 110384 110384 0 0.0
rodata 95032 95032 0 0.0
text 579140 579140 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822551 822551 0 0.0
bss 106740 106740 0 0.0
rodata 86216 86216 0 0.0
text 553312 553312 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785222 0 0.0
bss 111760 111760 0 0.0
rodata 90288 90288 0 0.0
text 508608 508608 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835579 0 0.0
bss 109408 109408 0 0.0
rodata 91500 91500 0 0.0
text 559236 559236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 760902 760902 0 0.0
bss 110820 110820 0 0.0
rodata 86808 86808 0 0.0
text 488796 488796 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841723 0 0.0
bss 109548 109548 0 0.0
rodata 93212 93212 0 0.0
text 563420 563420 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835315 0 0.0
bss 109444 109444 0 0.0
rodata 91460 91460 0 0.0
text 558856 558856 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2292608 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1250872 0 0.0
lock-app default (read/write) 2210080 2210080 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1168344 0 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489736 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 484416 0 0.0
lock-app qpg6100+debug (read only) 464692 464692 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459372 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763014 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529210 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited
Loading

PR #11878: Size comparison from 1adaf7a to 6e972b3

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1adaf7a 6e972b3 change % change
efr32 lighting-app BRD4161A (read only) 750448 750448 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750440 750440 0 0.0
BRD4161A+rpc (read only) 737972 737972 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 737964 737964 0 0.0
lock-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727496 727496 0 0.0
window-app BRD4161A (read only) 728488 728488 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728480 728480 0 0.0
esp32 all-clusters-app c3devkit (read only) 828884 828884 0 0.0
(read/write) 1220250 1220250 0 0.0
.dram0.bss 56736 56736 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164176 164176 0 0.0
.flash.text 828884 828884 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899907 899907 0 0.0
(read/write) 419564 419564 0 0.0
.dram0.bss 62088 62088 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192140 192140 0 0.0
.flash.text 894523 894523 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707304 707304 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622380 622380 0 0.0
lock-app k32w061+debug (read/write) 598736 598736 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523340 523340 0 0.0
shell k32w061+debug (read/write) 664112 664112 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577588 577588 0 0.0
linux all-clusters-app debug (read only) 1729833 1729833 0 0.0
(read/write) 126240 126240 0 0.0
.bss 56816 56816 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136789 136789 0 0.0
.text 1459090 1459090 0 0.0
bridge-app debug+rpc (read only) 1324829 1324829 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112028 0 0.0
.text 1115397 1115397 0 0.0
chip-tool debug (read only) 4986237 4986237 0 0.0
(read/write) 166280 166280 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118672 118672 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268458 268458 0 0.0
.text 4407269 4407269 0 0.0
lighting-app debug+rpc (read only) 1593937 1593937 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1329282 1329282 0 0.0
ota-provider-app debug (read only) 1272377 1272377 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114047 0 0.0
.text 1060738 1060738 0 0.0
ota-requestor-app debug (read only) 1358113 1358113 0 0.0
(read/write) 78784 78784 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125064 125064 0 0.0
.text 1133074 1133074 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1876257 1876257 0 0.0
(read/write) 318392 318392 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158021 158021 0 0.0
.text 1573106 1573106 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288000 2288000 0 0.0
.bss 179332 179332 0 0.0
.data 5216 5216 0 0.0
.heap 851896 851896 0 0.0
.text 1250600 1250600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273936 2273936 0 0.0
.bss 172196 172196 0 0.0
.data 5576 5576 0 0.0
.heap 858672 858672 0 0.0
.text 1236536 1236536 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249840 2249840 0 0.0
.bss 171084 171084 0 0.0
.data 5568 5568 0 0.0
.heap 859792 859792 0 0.0
.text 1212440 1212440 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156272 156272 0 0.0
.data 4968 4968 0 0.0
.heap 875208 875208 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865027 865027 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 582972 582972 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827395 827395 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557140 557140 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790082 790082 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512444 512444 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840427 840427 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563064 563064 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765730 765730 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492628 492628 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846567 846567 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567248 567248 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840127 840127 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562684 562684 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2298456 2298456 0 0.0
.bss 112320 112320 0 0.0
.data 2520 2520 0 0.0
.heap 918504 918504 0 0.0
.text 1256720 1256720 0 0.0
lock-app default (read/write) 2215944 2215944 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174208 1174208 0 0.0
qpg lighting-app qpg6100+debug (read only) 494080 494080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488760 488760 0 0.0
lock-app qpg6100+debug (read only) 469044 469044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463724 463724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768410 768410 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533546 533546 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited
Loading

PR #11878: Size comparison from 1adaf7a to 81e1bf2

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1adaf7a 81e1bf2 change % change
efr32 lighting-app BRD4161A (read only) 750448 750448 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750440 750440 0 0.0
BRD4161A+rpc (read only) 737972 737972 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 737964 737964 0 0.0
lock-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727496 727496 0 0.0
window-app BRD4161A (read only) 728488 728488 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728480 728480 0 0.0
esp32 all-clusters-app c3devkit (read only) 828884 828884 0 0.0
(read/write) 1220250 1220250 0 0.0
.dram0.bss 56736 56736 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164176 164176 0 0.0
.flash.text 828884 828884 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899907 899907 0 0.0
(read/write) 419564 419564 0 0.0
.dram0.bss 62088 62088 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192140 192140 0 0.0
.flash.text 894523 894523 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707304 707304 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622380 622380 0 0.0
lock-app k32w061+debug (read/write) 598736 598736 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523340 523340 0 0.0
shell k32w061+debug (read/write) 664112 664112 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577588 577588 0 0.0
linux all-clusters-app debug (read only) 1729833 1729833 0 0.0
(read/write) 126240 126240 0 0.0
.bss 56816 56816 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136789 136789 0 0.0
.text 1459090 1459090 0 0.0
bridge-app debug+rpc (read only) 1324829 1324829 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112028 0 0.0
.text 1115397 1115397 0 0.0
chip-tool debug (read only) 4986237 4986237 0 0.0
(read/write) 166280 166280 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118672 118672 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268458 268458 0 0.0
.text 4407269 4407269 0 0.0
lighting-app debug+rpc (read only) 1593937 1593937 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1329282 1329282 0 0.0
ota-provider-app debug (read only) 1272377 1272377 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114047 0 0.0
.text 1060738 1060738 0 0.0
ota-requestor-app debug (read only) 1358113 1358113 0 0.0
(read/write) 78784 78784 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125064 125064 0 0.0
.text 1133074 1133074 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1876257 1876257 0 0.0
(read/write) 318392 318392 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158021 158021 0 0.0
.text 1573106 1573106 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288000 2288000 0 0.0
.bss 179332 179332 0 0.0
.data 5216 5216 0 0.0
.heap 851896 851896 0 0.0
.text 1250600 1250600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273936 2273936 0 0.0
.bss 172196 172196 0 0.0
.data 5576 5576 0 0.0
.heap 858672 858672 0 0.0
.text 1236536 1236536 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249840 2249840 0 0.0
.bss 171084 171084 0 0.0
.data 5568 5568 0 0.0
.heap 859792 859792 0 0.0
.text 1212440 1212440 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156272 156272 0 0.0
.data 4968 4968 0 0.0
.heap 875208 875208 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865027 865027 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 582972 582972 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827395 827395 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557140 557140 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790082 790082 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512444 512444 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840427 840427 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563064 563064 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765730 765730 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492628 492628 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846567 846567 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567248 567248 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840127 840127 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562684 562684 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2298456 2298456 0 0.0
.bss 112320 112320 0 0.0
.data 2520 2520 0 0.0
.heap 918504 918504 0 0.0
.text 1256720 1256720 0 0.0
lock-app default (read/write) 2215944 2215944 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174208 1174208 0 0.0
qpg lighting-app qpg6100+debug (read only) 494080 494080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488760 488760 0 0.0
lock-app qpg6100+debug (read only) 469044 469044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463724 463724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768410 768410 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533546 533546 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited
Loading

PR #11878: Size comparison from 5bad4ed to be7b005

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5bad4ed be7b005 change % change
efr32 lighting-app BRD4161A (read only) 750448 750448 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750440 750440 0 0.0
BRD4161A+rpc (read only) 737972 737972 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 737964 737964 0 0.0
lock-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727496 727496 0 0.0
window-app BRD4161A (read only) 728488 728488 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728480 728480 0 0.0
esp32 all-clusters-app c3devkit (read only) 831588 831588 0 0.0
(read/write) 1223170 1223170 0 0.0
.dram0.bss 59424 59424 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164408 164408 0 0.0
.flash.text 831588 831588 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 902623 902623 0 0.0
(read/write) 422480 422480 0 0.0
.dram0.bss 64776 64776 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192368 192368 0 0.0
.flash.text 897239 897239 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707304 707304 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622380 622380 0 0.0
lock-app k32w061+debug (read/write) 598736 598736 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523340 523340 0 0.0
shell k32w061+debug (read/write) 664112 664112 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577588 577588 0 0.0
linux all-clusters-app debug (read only) 1745009 1745009 0 0.0
(read/write) 130440 130440 0 0.0
.bss 60272 60272 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63824 63824 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137461 137461 0 0.0
.text 1471890 1471890 0 0.0
bridge-app debug+rpc (read only) 1324829 1324829 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112028 0 0.0
.text 1115397 1115397 0 0.0
chip-tool debug (read only) 4999941 4999941 0 0.0
(read/write) 166376 166376 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118752 118752 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 269386 269386 0 0.0
.text 4419877 4419877 0 0.0
lighting-app debug+rpc (read only) 1593937 1593937 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1329282 1329282 0 0.0
ota-provider-app debug (read only) 1272377 1272377 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114047 0 0.0
.text 1060738 1060738 0 0.0
ota-requestor-app debug (read only) 1358113 1358113 0 0.0
(read/write) 78784 78784 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125064 125064 0 0.0
.text 1133074 1133074 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1876257 1876257 0 0.0
(read/write) 318392 318392 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158021 158021 0 0.0
.text 1573106 1573106 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290040 2290040 0 0.0
.bss 182028 182028 0 0.0
.data 5224 5224 0 0.0
.heap 849192 849192 0 0.0
.text 1252640 1252640 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273936 2273936 0 0.0
.bss 172196 172196 0 0.0
.data 5576 5576 0 0.0
.heap 858672 858672 0 0.0
.text 1236536 1236536 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249840 2249840 0 0.0
.bss 171084 171084 0 0.0
.data 5568 5568 0 0.0
.heap 859792 859792 0 0.0
.text 1212440 1212440 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156272 156272 0 0.0
.data 4968 4968 0 0.0
.heap 875208 875208 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865027 865027 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 582972 582972 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827395 827395 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557140 557140 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790082 790082 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512444 512444 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840427 840427 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563064 563064 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765730 765730 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492628 492628 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846567 846567 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567248 567248 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840127 840127 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562684 562684 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2302976 2302976 0 0.0
.bss 115008 115008 0 0.0
.data 2528 2528 0 0.0
.heap 915808 915808 0 0.0
.text 1261240 1261240 0 0.0
lock-app default (read/write) 2215944 2215944 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174208 1174208 0 0.0
qpg lighting-app qpg6100+debug (read only) 494080 494080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488760 488760 0 0.0
lock-app qpg6100+debug (read only) 469044 469044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463724 463724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768410 768410 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533546 533546 0 0.0

@mrjerryjohns mrjerryjohns mentioned this pull request Nov 20, 2021
Closed
@mrjerryjohns mrjerryjohns merged commit 244d8d4 into project-chip:master Nov 20, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 20, 2021
@bzbarsky-apple
Fix ZAP job failure on ToT.
306293e 
Presumably a bad merge from the combination of
project-chip#11868 and
project-chip#11878
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 20, 2021
Merged
bzbarsky-apple added a commit that referenced this pull request Nov 20, 2021
@bzbarsky-apple
Fix ZAP job failure on ToT. (#12066)
6cb75f4 
Presumably a bad merge from the combination of
#11868 and
#11878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@erjiaqing erjiaqing erjiaqing approved these changes

@LuDuda LuDuda LuDuda approved these changes

@msandstedt msandstedt msandstedt approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mrjerryjohns @andy31415 @LuDuda @msandstedt @erjiaqing @yunhanw-google @yufengwangca