Skip to content

Commit

Permalink
Apply review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tcarmelveilleux committed Jul 4, 2024
1 parent 2440138 commit aec9d3c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/app/data-model/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
# limitations under the License.
import("//build_overrides/chip.gni")

source_set("nullable-support") {
source_set("nullable") {
sources = [
"NullObject.h",
"Nullable.h",
]

public_deps = [
"${chip_root}/src/app/util:nullable-support-primitives",
"${chip_root}/src/app/util:nullable-primitives",
"${chip_root}/src/lib/core",
"${chip_root}/src/lib/core:error",
"${chip_root}/src/lib/core:string-builder-adapters",
Expand Down Expand Up @@ -52,7 +52,7 @@ source_set("data-model") {
"${chip_root}/src/protocols/interaction_model",
]

public_deps = [ ":nullable-support" ]
public_deps = [ ":nullable" ]
}

# Provides extensions that use heap and should be
Expand Down
2 changes: 1 addition & 1 deletion src/app/data-model/tests/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ chip_test_suite("tests") {
test_sources = [ "TestNullable.cpp" ]

public_deps = [
"${chip_root}/src/app/data-model:nullable-support",
"${chip_root}/src/app/data-model:nullable",
"${chip_root}/src/lib/core",
]
}
4 changes: 2 additions & 2 deletions src/app/util/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import("//build_overrides/chip.gni")
import("${chip_root}/src/app/common_flags.gni")

source_set("nullable-support-primitives") {
source_set("nullable-primitives") {
sources = [
"attribute-storage-null-handling.h",
"odd-sized-integers.h",
Expand Down Expand Up @@ -43,7 +43,7 @@ source_set("types") {
]

deps = [
":nullable-support-primitives",
":nullable-primitives",
"${chip_root}/src/app/common:attribute-type",
"${chip_root}/src/lib/core",
"${chip_root}/src/lib/core:encoding",
Expand Down

0 comments on commit aec9d3c

Please sign in to comment.