Convert resolver tests to TypeScript #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
bkeepers
suggested changes
Aug 22, 2018
There was a problem hiding this comment.
@karol-majewski thanks for the pull request! One small request, but otherwise looks good!
src/resolver.ts
Outdated
| @@ -4,11 +4,13 @@ export const resolve = (appFnId: string, opts?: ResolveOptions) => { | |||
| opts = opts || defaultOptions | |||
| // These are mostly to ease testing | |||
| const basedir = opts.basedir || process.cwd() | |||
| const resolver = opts.resolver || require('resolve').sync | |||
| const resolver: Resolver = opts.resolver || require('resolve').sync | |||
There was a problem hiding this comment.
Could require('resolve').sync get converted to import { sync } from 'resolve' and moved to the top?
There was a problem hiding this comment.
Absolutely. Done 👍
bkeepers
approved these changes
Aug 24, 2018
|
Thanks for your contribution to probot! 🎉 |
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #582.