Make wake-phase training faster #37
Conversation
zhezhaozz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 57.07% 57.04% -0.03%
==========================================
Files 12 12
Lines 1591 1590 -1
==========================================
- Hits 908 907 -1
Misses 683 683
Continue to review full report at Codecov.
|
| @@ -152,7 +152,7 @@ def _check_sources_and_locs(locs, n_sources, batchsize): | |||
| assert locs.shape[2] == 2 | |||
| assert len(n_sources) == batchsize | |||
| assert len(n_sources.shape) == 1 | |||
| assert max(n_sources) <= locs.shape[1] | |||
| # assert max(n_sources) <= locs.shape[1] | |||
There was a problem hiding this comment.
Please delete code rather than commenting it out
|
It seems there is an error in Have you seen this before @zzhaozhe-profolio , it's hard for me to trace it back to your code. |
|
@jeff-regier Circle.ci couldn't finish the test now, I'm
This is really weird. It's my first time having this error. It also passed on GPU so not sure. Let me re-run the test. |
|
The current pytorch-lightning package has a bug: Lightning-AI/pytorch-lightning#2213. While waiting for new version to correct that, tried to bypass the bug within the test file. |
* revise max function in simulated_dataset * try to fix error on circleci * delete commented code * adjust n_samples, passed on local CPU * bypass the bug in the package, wait for new version
This branch will focus on speed up the wake-phase training
closes #35