-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cromite to Mobile Browsers #2381
Open
austinhuang0131
wants to merge
5
commits into
privacyguides:main
Choose a base branch
from
austinhuang0131:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some because I never detailed them, correct?
do you think it is right for me to do so, i.e. to detail what has been implemented and what I think is missing?
do you happen to have a list of those implemented in brave as a comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like that then I would directly link to it.
There are various blog articles that I think one would have to go through. This however might be more relevant as it discusses what is randomized and what is blocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think has to do with testing at https://privacytests.org/android - where it seems to cover similar things to Brave but less than Mull. Not that I think Cromite should go as far as Mull does necessarily, to be clear. There are tradeoffs here, and I don't think Cromite intends to go as far as Firefox RFP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I didn't even know @arthuredelstein added cromite!
let's talk about it if you want. the results of each test should be interpreted.
But I don't think cromite is necessarily better than others: what cromite lacks is testing (and spread :) and I am okay with the fact that there are excellent sites like that and the duck duck test site because I use them to check regressions.
too bad there is no site that compare the same browser on different devices, not so much on functionality, but on how it looks to the Web sites.
creepjs, my reference website, has something similar, but it is hidden very well in the code.
Unfortunately, I don't know Mull so I can't answer that.
I don't know that one either.
I can tell you that my goal is to make all devices as similar as possible, as Tor does.