This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Fix infinite loop #1421
Merged
Fix infinite loop #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-bus-mapping
This was referenced May 19, 2023
ChihChengLiang
approved these changes
May 19, 2023
|
I'll merge this with one approve because it's a very small fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an infinite loop from a
Fromimplementation calling itself.Issue Link
Resolve #1420
Related #1417
Type of change
Contents
@ChihChengLiang found that this issue was introduced in #1406 and by debugging on the debug build I found the infinite loop (which caused the stack to overflow which terminated the program with a segfault). The segfault is not observed in the release build, I guess the compiler optimizes the recursive call into an infinite loop, so the stack is never exhausted.