This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Remove RwTableTag #1406
Merged
Remove RwTableTag #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
ed255
approved these changes
May 16, 2023
There was a problem hiding this comment.
LGTM! Nice work on the ongoing deduplication of types!
An effect of this PR is that the name RwTableTag is replaced by Target. We still use RwTableTag in the specs repo: https://github.com/search?q=repo%3Aprivacy-scaling-explorations%2Fzkevm-specs%20RwTableTag&type=code
Maybe we should update the specs to replace all instances of RwTableTag by Target to be consistent with this?
|
@ed255, thanks for the review! Replacing all instances of RwTableTag by Target in the spec makes sense to me. Let me file an issue. Update: the issue is filed here privacy-scaling-explorations/zkevm-specs#422 |
ChihChengLiang
force-pushed
the
rm-RwTableTag
branch
2 times, most recently
from
f750720
to
80ab93b
Compare
KimiWu123
approved these changes
May 17, 2023
|
LGTM! Great work! |
ChihChengLiang
force-pushed
the
rm-RwTableTag
branch
from
d1d81f4
to
16c6767
Compare
Merged
This was referenced May 19, 2023
ChihChengLiang
pushed a commit
that referenced
this pull request
May 19, 2023
### Description Fix an infinite loop from a `From` implementation calling itself. ### Issue Link Resolve #1420 Related #1417 ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) ### Contents @ChihChengLiang found that this issue was introduced in #1406 and by debugging on the debug build I found the infinite loop (which caused the stack to overflow which terminated the program with a segfault). The segfault is not observed in the release build, I guess the compiler optimizes the recursive call into an infinite loop, so the stack is never exhausted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RwTableTagcan be fully replaced byTarget.Issue Link
Part of #1391
Type of change
Contents
We add EnumIter, Hash, Expr to Target to let it serve different needs.
Note to reviewers: the
impl From<Target> for usizeis required by BinaryNumberConfig.