Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Implement TLOAD and TSTORE instructions #1761

Closed
zemse opened this issue Feb 7, 2024 · 0 comments · Fixed by #1797
Closed

Implement TLOAD and TSTORE instructions #1761

zemse opened this issue Feb 7, 2024 · 0 comments · Fixed by #1797
Assignees
Labels
T-feature Type: new features

Comments

@zemse
Copy link
Member

zemse commented Feb 7, 2024

Describe the feature you would like

These are new opcodes from the Cancun fork https://eips.ethereum.org/EIPS/eip-1153

Spec issue: privacy-scaling-explorations/zkevm-specs#511

Additional context

No response

@zemse zemse added the T-feature Type: new features label Feb 7, 2024
@ed255 ed255 added this to the Feature Completeness milestone Feb 8, 2024
@ed255 ed255 mentioned this issue Mar 21, 2024
5 tasks
@zemse zemse mentioned this issue Apr 2, 2024
3 tasks
@ed255 ed255 linked a pull request Apr 4, 2024 that will close this issue
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
#1761

- [x] Geth utils update
- [x] TLOAD TSTORE in bus mapping
- [x] TLOAD TSTORE in zkevm circuits 

<!--
### Description

[_PR description_]

### Issue Link

[_link issue here_]

### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Refactor (no updates to logic)

### Contents

- [_item_]

### Rationale

[_design decisions and extended information_]

### How Has This Been Tested?

[_explanation_]

<hr>

## How to fill a PR description 

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors.
By reading your description, they should easily understand the changes
proposed in this pull request.

MUST: Reference the issue to resolve

### Single responsibility

Is RECOMMENDED to create single responsibility commits, but not
mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

```
This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....
```

### Design choices

RECOMMENDED to:
- What types of design choices did you face?
- What decisions you have made?
- Any valuable information that could help reviewers to think critically
-->

---------

Co-authored-by: Miha Stopar <miha.stopar@xlab.si>
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-feature Type: new features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants