This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Keccak Circuit: Refactor word_rlc into word lo/hi #1385
Assignees
Milestone
Comments
10 tasks
1 task
1 task
ChihChengLiang
added a commit
that referenced
this issue
Jun 8, 2023
### Description Support word lo-hi in keccak circuit ### Issue Link #1385 ### Type of change - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Contents - Change the keccak circuit hash output format from RLC to word lo-hi. - Add convenient methods `map` for Word. This can easily map two limbs to other types. - Add a constructor for the zero known value word. ### Rationale ### Testss The following tests can pass if we remove math_gadget tests below ``` cargo test -p zkevm-circuits packed_multi_keccak_simple --features test ``` ``` zkevm-circuits/src/evm_circuit/util/math_gadget/add_words.rs zkevm-circuits/src/evm_circuit/util/math_gadget/cmp_words.rs zkevm-circuits/src/evm_circuit/util/math_gadget/lt_word.rs zkevm-circuits/src/evm_circuit/util/math_gadget/min_max_word.rs zkevm-circuits/src/evm_circuit/util/math_gadget/modulo.rs zkevm-circuits/src/evm_circuit/util/math_gadget/mul_add_words.rs ```
|
Fixed by #1434 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Specs: privacy-scaling-explorations/zkevm-specs#390
Depends on:
The text was updated successfully, but these errors were encountered: