This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 856
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[word lo/hi] keccak circuit to word (#1434)
### Description Support word lo-hi in keccak circuit ### Issue Link #1385 ### Type of change - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Contents - Change the keccak circuit hash output format from RLC to word lo-hi. - Add convenient methods `map` for Word. This can easily map two limbs to other types. - Add a constructor for the zero known value word. ### Rationale ### Testss The following tests can pass if we remove math_gadget tests below ``` cargo test -p zkevm-circuits packed_multi_keccak_simple --features test ``` ``` zkevm-circuits/src/evm_circuit/util/math_gadget/add_words.rs zkevm-circuits/src/evm_circuit/util/math_gadget/cmp_words.rs zkevm-circuits/src/evm_circuit/util/math_gadget/lt_word.rs zkevm-circuits/src/evm_circuit/util/math_gadget/min_max_word.rs zkevm-circuits/src/evm_circuit/util/math_gadget/modulo.rs zkevm-circuits/src/evm_circuit/util/math_gadget/mul_add_words.rs ```
- Loading branch information
1 parent
e9ac9fd
commit 40c9958
Showing
4 changed files
with
37 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters