fix: correct the pub types/fields(post frontend-backend split) #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duguorong009
changed the title
|
@duguorong009 CI is not passing. Could you address the errors first? |
@CPerezz Fixed the CI issues. |
ed255
requested changes
Feb 16, 2024
CPerezz
approved these changes
Feb 20, 2024
| @@ -3,6 +3,7 @@ use halo2_middleware::ff::Field; | |||
| use std::fmt::{self, Debug}; | |||
|
|
|||
| /// Expressions involved in a lookup argument, with a name as metadata. | |||
| /// TODO: possible to move to "halo2_backend", if moved, pub(crate) fields. | |||
There was a problem hiding this comment.
This issue is related to #266 .
FYI, I added the TODO comment for easy lookup.
There was a problem hiding this comment.
For the best, I added this issue to list of #266.
#266 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Changes
halo2_common,halo2_frontend,halo2_backend