[post frontend-backend split] Move types/functions from common to frontend/backend

[ed255]

After the frontend-backend split a new package halo2_common was added that contains functions and types used by both frontend and backend. These functions/types are now pub but are meant for internal usage only of the halo2 repository.

As future work we should try to move more stuff to either frontend/backend, creating mirror lightweight types as necessary; or splitting functionality between frontend and backend. After types/functions are moved to frontend/backend, they should recover the pub(crate) status.

Here's a non-exhaustive list of affected types:

• halo2_common::poly::Polynomial -> Backend [post frontend-backend split] Move poly to backend #257
• halo2_common::arithmetic::* -> Frontend Backend refactor: move the halo2_common::arithmetic to halo2_backend(post fe-be split) #281
• halo2_common::plonk::Challenge* -> Backend refactor: move some types from common to backend (post-split)(plonk-0) #287
• halo2_common::plonk::transcript -> Backend refactor: move some types from common to backend (post-split)(plonk-0) #287
• halo2_common::plonk::error::Error -> Backend / Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::plonk::circuit::Expression -> Backend / Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::plonk::circuit::{sealed, *Phase} -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::plonk::circuit::Selector -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::plonk::circuit::Circuit -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::plonk::permutation::Assembly -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::plonk::lookup::Argument -> Backend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::circuit::Value -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::circuit::Chip -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::circuit::Region* -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::circuit::layouter::* -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::circuit::floor_planner::* -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::circuit::Table -> Frontend Remove dependency to common ConstraintSystem in the backend #290
• halo2_common::poly::Queires -> Backend refactor: remove the halo2_common crate(post-split) #298
• halo2_common::multicore::TryFoldAndReduce -> Middleware refactor: remove the halo2_common crate(post-split) #298
• halo2_common::helpers::{SerdeFormat, CurveRead, SerdeCurveAffine, SerdePrimeField, pack, unpack} -> Backend refactor: remove the halo2_common crate(post-split) #298

Blocked by #254

[ed255]

I'm currently working on halo2_common::plonk::circuit::Expression (and will also probably work on the halo2_common::plonk::circuit::ConstraintSystem.
My current approach is to define a single Expression type that can be generic and instantiated into 2 cases: one for the frontend, and one for the backend.

[duguorong009]

I work on task - move halo2_common::arithmetic to halo2_backend. #281

[duguorong009]

I work on task - move plonk::Challenge* & plonk::transcript from common to backend. #287

[ed255]

@duguorong009 will work on the remaining points of this issue.

[duguorong009]

@ed255
I've just merged the #298 .
After this, there is no halo2_common crate(the post-split tech debt) in the repo.
Hence, I think we can close this issue as completed.

What do you think?

[ed255]

@ed255 I've just merged the #298 . After this, there is no halo2_common crate(the post-split tech debt) in the repo. Hence, I think we can close this issue as completed.

What do you think?

I agree! This issue has now been completed, I'll just close it; thanks for the reminder!