Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WPGraphQL v1.13+ compatibility #165

Conversation

jasonbahl
Copy link
Collaborator

@jasonbahl jasonbahl commented Dec 2, 2022

WPGraphQL v1.13.0 introduced Connection and Edge Interfaces which enforce connections to connect to a Type that is a Node.

This updates the BlockEditorContentNode to implement the Node interface to play nicely with WPGraphQL v1.13+

NOTE: This PR also updates the code sniffer rules and fixes issues brought up by code sniffs

closes #164

…pwpcs

- composer update
- update phpcs.xml based on latest wp-graphql
- run composer fix-cs to fix code style inconsistencies
- manually fix issues related to composer check-cs (set construct methods to public, etc)
- separate classes into their own files (RegistryNotSourcedException, ServerException)
- replace json_encode with wp_json_encode throughout
- implement the `Node` interface on BlockEditorContentNode.php (adds compatibility with WPGraphQL v1.13 + )
@jasonbahl jasonbahl self-assigned this Dec 2, 2022
@jasonbahl jasonbahl merged commit 9aeb21b into pristas-peter:master Dec 2, 2022
@pristas-peter
Copy link
Owner

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants