Upgrade @primer/stylelint-config to latest version 13.0.1 #3101
+632
−1,353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
langermank
reviewed
Sep 20, 2024
| @@ -492,7 +502,7 @@ nav-list { | |||
|
|
|||
| & .ActionListItem-multiSelectIconRect { | |||
| fill: var(--bgColor-default); | |||
| border: var(--borderWidth-thin, 1px) solid var(--control-borderColor-rest); | |||
| border: var(--borderWidth-thin, var(--borderWidth-thin)) solid var(--control-borderColor-rest); | |||
There was a problem hiding this comment.
Suggested change
| border: var(--borderWidth-thin, var(--borderWidth-thin)) solid var(--control-borderColor-rest); | |
| border: var(--borderWidth-thin) solid var(--control-borderColor-rest); |
Comment on lines
+44
to
46
| /* stylelint-disable-next-line primer/colors */ | ||
| color: var(--control-borderColor-danger); | ||
| fill: var(--control-borderColor-danger); |
There was a problem hiding this comment.
Suggested change
| /* stylelint-disable-next-line primer/colors */ | |
| color: var(--control-borderColor-danger); | |
| fill: var(--control-borderColor-danger); | |
| color: var(--control-danger-fgColor-rest); | |
| fill: var(--control-danger-fgColor-rest); |
Comment on lines
+57
to
59
| /* stylelint-disable-next-line primer/colors */ | ||
| color: var(--control-borderColor-success); | ||
| fill: var(--control-borderColor-success); |
There was a problem hiding this comment.
Suggested change
| /* stylelint-disable-next-line primer/colors */ | |
| color: var(--control-borderColor-success); | |
| fill: var(--control-borderColor-success); | |
| color: var(--fgColor-success); | |
| fill: var(--fgColor-success); |
| @@ -154,7 +162,7 @@ | |||
| transition: 80ms cubic-bezier(0.33, 1, 0.68, 1); | |||
| transition-property: color, background-color, box-shadow, border-color; | |||
| padding-inline: var(--control-medium-paddingInline-condensed); | |||
| padding-block: calc(var(--control-medium-paddingBlock, 6px) - var(--borderWidth-thin, 1px)); | |||
| padding-block: calc(var(--control-medium-paddingBlock, var(--base-size-6)) - var(--borderWidth-thin, 1px)); | |||
There was a problem hiding this comment.
Suggested change
| padding-block: calc(var(--control-medium-paddingBlock, var(--base-size-6)) - var(--borderWidth-thin, 1px)); | |
| padding-block: calc(var(--control-medium-paddingBlock) - var(--borderWidth-thin)); |
| display: flex; | ||
| width: var(--base-size-16); | ||
| /* stylelint-disable-next-line primer/spacing */ | ||
| margin-top: 0.063rem; |
| @@ -59,7 +62,7 @@ | |||
| & .Box-btn-octicon { | |||
| &.btn-octicon { | |||
| padding: var(--stack-padding-spacious); | |||
| margin: calc(var(--stack-gap-spacious) * -1) calc(var(--stack-gap-spacious) * -1); | |||
| margin: calc(var(--stack-gap-spacious) * -1); | |||
Comment on lines
+284
to
+285
| padding: var(--control-medium-paddingInline-spacious); | ||
| margin: calc(var(--controlStack-small-gap-spacious) * -1); |
There was a problem hiding this comment.
Same with these, but not sure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Screenshots
Integration
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.