Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to the latest versions of rubocop-rails-accessibility and erblint-github #3100

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Upgrade to the latest versions of rubocop-rails-accessibility and erblint-github #3100

merged 6 commits into from
Sep 19, 2024

Conversation

camertron
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR upgrades PVC to use the latest versions rubocop-rails-accessibility and erblint-github in an attempt to improve our accessibility scorecard.

Integration

No changes necessary in production.

List the issues that this change affects.

Closes https://github.com/github/primer/issues/3965
Closes https://github.com/github/primer/issues/3964

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@camertron camertron added the skip changeset Pull requests that don't change the library output label Sep 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fe3e811

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review September 19, 2024 16:46
@camertron camertron requested review from a team as code owners September 19, 2024 16:46
@jonrohan jonrohan merged commit 53a11d2 into main Sep 19, 2024
37 checks passed
@jonrohan jonrohan deleted the upgrade_a11y_gems branch September 19, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @jonrohan