Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading content parameter #3074

Merged
merged 28 commits into from
Sep 18, 2024
Merged

Add loading content parameter #3074

merged 28 commits into from
Sep 18, 2024

Commits on Sep 10, 2024

  1. Add loading content slot

    @owenniblock
    owenniblock committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7b9e7a9 View commit details
    Browse the repository at this point in the history

  2. Generating component snapshots

    @owenniblock @github-actions
    owenniblock authored and github-actions[bot] committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    32c976a View commit details
    Browse the repository at this point in the history

  3. Add changeset

    @owenniblock
    owenniblock committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1a12c3c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Change approach to use props instead of a slot

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b10b725 View commit details
    Browse the repository at this point in the history

  2. Prefer .present, only show new div when content exists

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b80c16a View commit details
    Browse the repository at this point in the history

  3. Remove trailing whitespace

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    852cfce View commit details
    Browse the repository at this point in the history

  4. WIP on tests

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3c3d059 View commit details
    Browse the repository at this point in the history

  5. Don't need hash on id

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6ba6181 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into add-loading-content-slot

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    015a5a8 View commit details
    Browse the repository at this point in the history

  7. Ruby brain fail

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1c2f7a7 View commit details
    Browse the repository at this point in the history

  8. Generating component snapshots

    @owenniblock @github-actions
    owenniblock authored and github-actions[bot] committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d7fc656 View commit details
    Browse the repository at this point in the history

  9. Tests

    @owenniblock
    owenniblock committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    98115f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Move tests to component test file

    @owenniblock
    owenniblock committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1108698 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-loading-content-slot

    @owenniblock
    owenniblock committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d9afcc8 View commit details
    Browse the repository at this point in the history

  3. Add note about potential flakiness

    @owenniblock
    owenniblock committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ef48c16 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Whoops, merge

    @owenniblock
    owenniblock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    714810a View commit details
    Browse the repository at this point in the history

  2. Always show loading content

    @owenniblock
    owenniblock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7ccb3b1 View commit details
    Browse the repository at this point in the history

  3. Remove screenshots so they'll get re-generated

    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e3e21e8 View commit details
    Browse the repository at this point in the history

  4. Add interaction subject js to new preview templates

    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fbbb522 View commit details
    Browse the repository at this point in the history

  5. Comment to explain weirdness

    @owenniblock
    owenniblock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    13a33fe View commit details
    Browse the repository at this point in the history

  6. Fix linting errors

    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    eb51088 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'add-loading-content-slot' of github.com:primer/view_com… 

    …ponents into add-loading-content-slot
    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    49c9ac2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into add-loading-content-slot

    @owenniblock
    owenniblock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    082208f View commit details
    Browse the repository at this point in the history

  9. Update static files

    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    15c6242 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'add-loading-content-slot' of github.com:primer/view_com… 

    …ponents into add-loading-content-slot
    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c7b14b9 View commit details
    Browse the repository at this point in the history

  11. Generating component snapshots

    @camertron @github-actions
    camertron authored and github-actions[bot] committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    101618b View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into add-loading-content-slot

    @camertron
    camertron committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    033f284 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Remove old comment

    @owenniblock
    owenniblock committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7e444f1 View commit details
    Browse the repository at this point in the history