Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vite; stop updating bundle in CI #3060

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Upgrade Vite; stop updating bundle in CI #3060

merged 2 commits into from
Sep 5, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Sep 5, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

We're seeing some CI breakage due to running bundle upgrade and pulling in incompatible Ruby + js libraries. This PR fixes the issue by 1) upgrading vite-ruby-plugin, vite, and vite_rails, and 2) avoiding running bundle update in CI.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

This change affects test/dev only.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: 4b494a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron added the skip changeset Pull requests that don't change the library output label Sep 5, 2024
@camertron camertron marked this pull request as ready for review September 5, 2024 17:07
@camertron camertron requested a review from a team as a code owner September 5, 2024 17:07
@camertron camertron requested review from TylerJDev and keithamus and removed request for TylerJDev September 5, 2024 17:07
@keithamus keithamus merged commit 14602d0 into main Sep 5, 2024
38 checks passed
@keithamus keithamus deleted the upgrade_vite branch September 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants