Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tooltip support to IconButton #1062

Merged
merged 33 commits into from
Aug 1, 2022
Merged

Add Tooltip support to IconButton #1062

merged 33 commits into from
Aug 1, 2022

Commits on Mar 17, 2022

  1. Render IconButton with a template instead of call

    @hectahertz
    hectahertz committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    9885abc View commit details
    Browse the repository at this point in the history

  2. Add Tooltip support to IconButton

    @hectahertz
    hectahertz committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    e33fdce View commit details
    Browse the repository at this point in the history

  3. Add IconButton with tooltip to Storybook

    @hectahertz
    hectahertz committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    61bd56a View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @hectahertz
    hectahertz committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    6e631fc View commit details
    Browse the repository at this point in the history

  5. Update app/components/primer/icon_button.rb 

    Co-authored-by: Kate Higa  <16447748+khiga8@users.noreply.github.com>
    @hectahertz @khiga8
    hectahertz and khiga8 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    6c8c8e8 View commit details
    Browse the repository at this point in the history

  6. Add DEFAULT_TOOLTIP_TYPE to IconButton

    @hectahertz
    hectahertz committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    9b74f5d View commit details
    Browse the repository at this point in the history

  7. docs: build docs

    @actions-user
    actions-user committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    c8a0cec View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    c54b591 View commit details
    Browse the repository at this point in the history

  2. Update IconButton API to always include tooltips

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    ee0ba40 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hectahertz/add-tooltip-to-iconbutton' of https://github… 

    ….com/primer/view_components into hectahertz/add-tooltip-to-iconbutton
    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    1b17f52 View commit details
    Browse the repository at this point in the history

  4. docs: build docs

    @actions-user
    actions-user committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    ffd1221 View commit details
    Browse the repository at this point in the history

  5. Update storybook

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    5a3e120 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'hectahertz/add-tooltip-to-iconbutton' of https://github… 

    ….com/primer/view_components into hectahertz/add-tooltip-to-iconbutton
    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3044a0c View commit details
    Browse the repository at this point in the history

  7. Fixup: aria-label access

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    65b27d3 View commit details
    Browse the repository at this point in the history

  8. Support aria-description

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    ccc73b8 View commit details
    Browse the repository at this point in the history

  9. Improve IconButton docs

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    df4fc78 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @hectahertz
    hectahertz committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    9198869 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Update comment on app/components/primer/icon_button.rb 

    Co-authored-by: Kate Higa  <16447748+khiga8@users.noreply.github.com>
    @hectahertz @khiga8
    hectahertz and khiga8 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    5d6919a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @manuelpuyol
    manuelpuyol committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    09a0ace View commit details
    Browse the repository at this point in the history

  2. Refactor tooltip to use a splatted hash instead of listing all arguments

    @manuelpuyol
    manuelpuyol committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    31c6093 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @hectahertz
    hectahertz committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    1374f2c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @jonrohan
    jonrohan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    abaf23c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @hectahertz
    hectahertz committed May 13, 2022
    Configuration menu
    Copy the full SHA
    143496b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @hectahertz
    hectahertz committed May 17, 2022
    Configuration menu
    Copy the full SHA
    6ac3ee8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @jonrohan
    jonrohan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    f1b7711 View commit details
    Browse the repository at this point in the history

  2. Create orange-fishes-juggle.md

    @jonrohan
    jonrohan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    84e34fb View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    @jonrohan
    jonrohan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9545237 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @jonrohan
    jonrohan committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f580d06 View commit details
    Browse the repository at this point in the history

  2. Rename to Beta::BaseButton

    @jonrohan
    jonrohan committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ad50c0d View commit details
    Browse the repository at this point in the history

  3. Creating icon_button_preview

    @jonrohan
    jonrohan committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c94dd38 View commit details
    Browse the repository at this point in the history

  4. Updating tooltip preview labels

    @jonrohan
    jonrohan committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ea9635d View commit details
    Browse the repository at this point in the history

  5. Completing icon_button tests

    @jonrohan
    jonrohan committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4978f99 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into hectahertz/add-tooltip-to-iconbutton

    @jonrohan
    jonrohan committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    113aea1 View commit details
    Browse the repository at this point in the history