Prefer .present, only show new div when content exists

primer · Sep 13, 2024 · b80c16a · b80c16a
1 parent b10b725
commit b80c16a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/components/primer/alpha/select_panel.html.erb b/app/components/primer/alpha/select_panel.html.erb
@@ -71,7 +71,9 @@
                   )) do %>
                     <div data-hide-on-error>
                       <%= render Primer::Beta::Spinner.new(aria: { label: @loading_label, describedby: @loading_description_id }, data: { target: "select-panel.bodySpinner" }) %>
-                      <div id="<%= @loading_description_id %>" aria-hidden="true"><%= @loading_description %></div>
+                      <% if @loading_description.present? %>
+                        <div id="<%= @loading_description_id %>" aria-hidden="true"><%= @loading_description %></div>
+                      <% end %>
                     </div>
                     <div data-show-on-error hidden data-target="select-panel.fragmentErrorElement">
                       <% if preload_error_content? %>

diff --git a/app/components/primer/alpha/select_panel.rb b/app/components/primer/alpha/select_panel.rb
@@ -413,7 +413,7 @@ def initialize(
         @dynamic_aria_label_prefix = dynamic_aria_label_prefix
         @loading_label = loading_label
         @loading_description_id = nil
-        unless loading_description.nil?
+        if loading_description.present?
           @loading_description_id = "#{@panel_id}-loading-description"
         end
         @loading_description = loading_description