Add missing if statement in #waitForCondition (#2961)

primer · Jul 22, 2024 · b662625 · b662625
1 parent 0f1b9d8
commit b662625
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/rotten-apples-greet.md b/.changeset/rotten-apples-greet.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Ensure condition is checked when mutations occur in SelectPanelElement.
diff --git a/app/components/primer/alpha/select_panel_element.ts b/app/components/primer/alpha/select_panel_element.ts
@@ -250,8 +250,10 @@ export class SelectPanelElement extends HTMLElement {
       body()
     } else {
       const mutationObserver = new MutationObserver(() => {
-        body()
-        mutationObserver.disconnect()
+        if (condition()) {
+          body()
+          mutationObserver.disconnect()
+        }
       })
 
       mutationObserver.observe(this, {childList: true, subtree: true})