Remove classes that were only used for testing purposes and not for s…

…tyling
primer · Aug 28, 2024 · b0e8b11 · b0e8b11
1 parent d08521d
commit b0e8b11
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/app/components/primer/beta/link.html.erb b/app/components/primer/beta/link.html.erb
@@ -1,13 +1,13 @@
 <%= render Primer::ConditionalWrapper.new(condition: tooltip?, trim: true, tag: :span, position: :relative) do %>
   <%= render(Primer::BaseComponent.new(trim: true, **@system_arguments)) do %>
     <% if leading_visual %>
-      <span class="Link-visual Link-leadingVisual">
+      <span>
         <%= leading_visual %>
       </span>
     <% end %>
     <%= content %>
     <% if trailing_visual %>
-      <span class="Link-visual Link-trailingVisual">
+      <span>
         <%= trailing_visual %>
       </span>
     <% end %>

diff --git a/test/components/beta/link_test.rb b/test/components/beta/link_test.rb
@@ -100,16 +100,18 @@ def test_renders_leading_visual_icon
     end
 
     assert_selector("a[href='http://google.com']")
-    assert_selector(".Link-visual.Link-leadingVisual .octicon-plus")
+    assert_selector(".octicon-plus")
   end
 
   def test_renders_trailing_visual_icon
     render_inline(Primer::Beta::Link.new(href: "http://google.com")) do |component|
-      component.with_trailing_visual_icon(icon: "plus")
+      component.with_leading_visual_icon(icon: "plus")
+      component.with_trailing_visual_icon(icon: "alert")
       "content"
     end
 
     assert_selector("a[href='http://google.com']")
-    assert_selector(".Link-visual.Link-trailingVisual .octicon-plus")
+    assert_selector("a span:first-child .octicon-plus")
+    assert_selector("a span:nth-child(2) .octicon-alert")
   end
 end