Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to stylelint 15.10.2 #356

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Upgrading to stylelint 15.10.2 #356

merged 6 commits into from
Aug 17, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Aug 17, 2023

The main objective of this PR is to get to stylelint v15. But we did a few other things also

  1. Got rid of yarn we're removing from other repos and removing here too.
  2. Updated config for new version 15, removing deprecated rules and adding settings for new ones.

We ran the updated config in a PR in dotcom to make sure the rules work with existing CSS https://github.com/github/github/pull/285111

Co-authored-by: Katie Langerman <langermank@users.noreply.github.com>
@jonrohan jonrohan requested a review from a team as a code owner August 17, 2023 21:10
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: fa5acdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/stylelint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets gooooo

@jonrohan jonrohan merged commit fdf5660 into main Aug 17, 2023
4 checks passed
@jonrohan jonrohan deleted the upgrade_stylelint branch August 17, 2023 23:08
@primer-css primer-css mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants