Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue in utilities plugin #274

Merged
merged 2 commits into from
May 27, 2022
Merged

Fixing issue in utilities plugin #274

merged 2 commits into from
May 27, 2022

Conversation

jonrohan
Copy link
Member

I was noticing that the plugin was missing some cases in practice. For example it would miss the .foo class in the example below.

body {
  font-size: 12px;
}

.foo {
  margin-top: $spacer-1;
}

Example in code

This was because of the return false in my selector check. This was stopping the processing of the rest of the page when it happened.

I added a test case for this bug.

@jonrohan jonrohan requested a review from a team as a code owner May 26, 2022 21:01
@jonrohan jonrohan requested a review from langermank May 26, 2022 21:01
@changeset-bot
Copy link

changeset-bot bot commented May 26, 2022

🦋 Changeset detected

Latest commit: 4820ad9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/stylelint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan merged commit 4ba7018 into main May 27, 2022
@jonrohan jonrohan deleted the fixing_utility_plugin branch May 27, 2022 02:36
@primer-css primer-css mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants